Closed Bug 1528914 Opened 1 year ago Closed 1 year ago

Tidy a bit the relationship between nsPresContext and nsDocShell.

Categories

(Core :: Layout, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Make it always forward to the document's docshell. We rely on it being setup by the time our stuff runs, and we cannot have multiple pres contexts per document in different docshells anymore.

This allows me to also move some state to the document (about whether it's currently loaded in a chrome docshell (nsPresContext::mIsChrome) and whether it's a chrome origin image (nsPresContext::mIsChromeOriginImage), which will help for bug 1490401 / bug 1418159.

Make it always forward to the document's docshell. We rely on it being setup by
the time our stuff runs, and we cannot have multiple pres contexts per document
in different docshells anymore.

This allows me to also move some state to the document (about whether it's
currently loaded in a chrome docshell (nsPresContext::mIsChrome) and whether
it's a chrome origin image (nsPresContext::mIsChromeOriginImage), which will
help for bug 1490401 / bug 1418159.

The pres context already relies on having the docshell available and we don't
handle dynamic changes to it.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ed0dbecf030
Tidy the relationship between the doc shell and the pres context. r=qdot
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.