1528966 - Add new CFR UI template for Pin tab and message schema

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Andrei Oprea [:andreio]]

Attachment: Screenshot 2019-02-19 at 15.04.03.png

Add a new CFR template for the Pin Tab recommendation message (see attachment).
This will include an animation which we ideally would like to have in WebP format.
You can how it will all look together in this video.

Comment 1

[Andrei Oprea [:andreio]]

Given the concerns in bug 1506996 are there any issues with adding an animation inside a popup notification? This would only be shown when the popup expands, when the user clicks the notification badge in the awesomebar.
The attachment has the animation as gif, would the WebP format be better for this?

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Yes. It should be fine to use an animated image in a popup. Typically we've used APNGs in the chrome instead of gifs or WebPs. If there's no big advantage to using WebP I'd suggest just sticking with an APNG

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4824

Comment 4

[Andrei Oprea [:andreio]]

Attachment: datareview

We already collect a similar ping part of the CFR Addon recommendation messages. In this PR we added a different name to the ping event to reflect that it is in fact the Pin Tab message.

Comment 5

[Chris H-C :chutten]

Comment on attachment 9048230 [details]
datareview

This has to be data-review- for now because the data collection isn't documented. I'm not 100% sure but it appears as though CFR collections are documented as part of Activity Stream's data documentation which is over here: https://github.com/mozilla/activity-stream/blob/master/docs/v2-system-addon/data_events.md

As far as I can tell from a quick look the documentation should be the only missing piece, so when it's added put this back up for data review.

Comment 6

[Andrei Oprea [:andreio]]

Attachment: Bug 1528966 - Add new CFR UI template for Pin tab message

Comment 7

[Andrei Oprea [:andreio]]

Comment on attachment 9048230 [details]
datareview

Sorry about that. Updated our [docs](https://github.com/mozilla/activity-stream/blob/a813da71d9b54095dfaf95c48b425d02e79a68e9/docs/v2-system-addon/data_events.md#cfr-interaction-pings-for-all-the-prerelease-channels-and-shield-experiment) in the [github PR](https://github.com/mozilla/activity-stream/pull/4824)

A mention related to the `bucked_id` that shows up in the event: there is only 1 possible bucket but this can be triggered by 48 different domains.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b1ceca1985b
Add new CFR UI template for Pin tab message r=k88hudson

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/3b1ceca1985b

Comment 11

[Chris H-C :chutten]

Comment on attachment 9048230 [details]
datareview

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is documented in Activity Stream's [data documentation](https://github.com/mozilla/activity-stream/blob/a813da71d9b54095dfaf95c48b425d02e79a68e9/docs/v2-system-addon/data_events.md#cfr-interaction-pings-for-all-the-prerelease-channels-and-shield-experiment).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is part of Activity Stream so can be controlled through Activity Stream's preferences or Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Nan Jiang and Andrei Oprea are responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 12

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/a014bada4619