1529340 - CFR Pinned tabs popup animation

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Andrei Oprea [:andreio]]

The animation should loop by default.
When you click the pause button the animation should be replaced with a static asset (some frame of the animation).
When you click the resume button the animation should start to loop again.

Comment 1

[Andrei Oprea [:andreio]]

I think toolkit.cosmeticAnimations.enabled is meant to disable all animations in the browser. We should respect this preference for the animation in our dropdown.

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Amy is going to provide the assets required.

Comment 3

[Andrei Oprea [:andreio]]

Attachment: pinned_tab-apng.png

Comment 4

[Andrei Oprea [:andreio]]

Attachment: play icon.svg

Comment 5

[Andrei Oprea [:andreio]]

Attachment: pause icon.svg

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

We are still missing the static image that shows up when the user hits pause. Amy or Andrei, does this exist already?

Also, the play/pause need a different color in dark theme. Those can probably be set with CSS but we need the color value.

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

In the Feb 20 meeting (CFR crossfunctional) notes, it says we decided to: Loop, and then replace with static image once paused.

We don't need to implement the play part after the user pauses. I think the reasoning was that users will only hit pause if the animation is bugging them so there is no reason to provide the ability to restart.

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #6)

We are still missing the static image that shows up when the user hits pause. Amy or Andrei, does this exist already?

Also, the play/pause need a different color in dark theme. Those can probably be set with CSS but we need the color value.

Oh, and can we get an animated PNG in the right dimensions? It looks like the width allocated in the doorhanger is about 310-315px.

Comment 9

[Andrei Oprea [:andreio]]

Attachment: recommend_icon.svg

Comment 10

[Ricky Rosario [:rrosario, :r1cky]]

I have all the assets now. Clearing the NI

Comment 11

[Ricky Rosario [:rrosario, :r1cky]]

Attachment: Bug 1529340 - CFR Pinned tabs popup animation

MozReview-Commit-ID: FTr5Pi7ySbY

Comment 12

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4833

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b52eb25bbe9c
CFR Pinned tabs popup animation r=k88hudson

Comment 14

[Dorel Luca [:dluca]]

Backed out changeset b52eb25bbe9c (bug 1529340) for Browser-Chrome failures in browser/base/content/test/static/browser_parsable_css.js

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=232327792&repo=autoland&lineNumber=2373

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=b52eb25bbe9c8b4ecf2bdc807e0f71740ff0870c

Backout:
https://hg.mozilla.org/integration/autoland/rev/989ecfe52f3a7dd426374d71927c10db5b3e37ce

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a3b22130b99
CFR Pinned tabs popup animation r=k88hudson

Comment 16

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/6a3b22130b99

Comment 17

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/a014bada4619