152899 - mid-air collision while marking a dup duplicates "this bug has been marked..."

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Jesse Ruderman]

Steps:
1. Load a bug.
2. Someone else adds a comment.
3. Try to mark the bug as a dup (in my case, without adding a comment).
4. Click through the "mid-air collision" page.

Result: the "this bug has been marked as a duplicate of" line is duplicated
(example: http://bugzilla.mozilla.org/show_bug.cgi?id=152860#c2)

Comment 1

[Bradley Baetz (:bbaetz)]

Is this a regression? We're doing midair checks after setting FORM{'COMMENT'},
which then goes through to the hidden data

Comment 2

[timeless]

*** Bug 153711 has been marked as a duplicate of this bug. ***

Comment 3

[Daniel Clemente]

It also happened to me with bug 178150...

Comment 4

[Frédéric Buclin]

*** Bug 276216 has been marked as a duplicate of this bug. ***

Comment 5

[Vlad Dascalu]

*** Bug 276216 has been marked as a duplicate of this bug. ***

Comment 6

[Dave Miller [:justdave]]

This bug has been around pretty much forever, and although it's annoying, it's
only a cosmetic issue.  If someone patches it, I'll take it for 2.18, but I
won't block release on it.

Comment 7

[Frédéric Buclin]

Will be trivial to fix as soon as bug 225221 gets fixed. I already know how to
do this.

Note to self: append "this bug has been marked..." to the initial comment only
when adding the corresponding comment to the original bug, that is: in the 'if
($duplicate)' block around line 1840 in process_bug.cgi instead of line 1055.

Comment 8

[Frédéric Buclin]

I won't have time to play with it before the 2.22 freeze

Comment 9

[Frédéric Buclin]

Fixed by bug 353656