1529035 - Discovery Stream layout delay causing cache to be used

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Scott [:thecount] Downe]

If the layout returns with a delay and the client has a layout cache, the client uses the cache, then when the delayed layout returns, it updates any open tabs.

We should probably not use the cache if the pref has changed and we're waiting for a response to succeed/fail. If it fails, we can then use cache.

Comment 1

[Scott [:thecount] Downe]

Need info on myself to add steps to test.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4816

Comment 3

[Scott [:thecount] Downe]

To test:

1. Setup two tabs from the same profile side by side.
2. Tab 1 can be about:config
3. Tab 2 can be about:home
4. From tab 1, set the pref browser.newtabpage.activity-stream.discoverystream.config to {"api_key_pref":"extensions.pocket.oAuthConsumerKey","enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=$apiKey&layout_variant=basic"}
5. Tab 2 should render basic.
6. Update pref from step 4 to {"api_key_pref":"extensions.pocket.oAuthConsumerKey","enabled":true,"show_spocs":true,"layout_endpoint":"https://gist.githubusercontent.com/ScottDowne/fedc94f5ea33b320083fc302987a3be2/raw/06492b8d7caab27c3cd6c0c3e10b93f38240ff11/gistfile1.txt"}

expected, it should load cleanly, with no jank. If you see jank it'll be seeing top sites first before the rest is ready something's not working.

Comment 4

[Scott [:thecount] Downe]

For some reason this wasn't linked, closing as fixed.

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/7a266c35cb30