1529141 - Firefox Preferences "Home" section has unnecessarily wide content (triggering truncation & horizontal scrollbar), due to long unbroken sentence about "Content Discovery in Firefox Home"

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Daniel Holbert [:dholbert]]

STR:

1. Make your Firefox window ~1024 pixels wide. (This is a little over half the width of my 24" Dell Monitor width).

2. Visit about:preferences#home

ACTUAL RESULTS:
The content doesn't fit -- we trigger a horizontal scrollbar.

EXPECTED RESULTS:
Content should be less wasteful of space / more responsive to window size. At some threshold a scrollbar will probably be needed, but 1024px feels quite wide to be already below that threshold.

Every other preferences pane and every "about:addons" section fits nicely in this window-size. It's only this #home section of Preferences that is too wide.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot

Comment 2

[Daniel Holbert [:dholbert]]

The large content-width here seems to entirely be caused by a <description> tag with this content, which we don't linebreak for some reason:

Content Discovery in Firefox Home allows you to discover high-quality, relevant articles from across the web.

If I delete that element in devtools, then the whole layout adjusts and fits my window size nicely.

So it seems that the solution here is to allow that long sentence to be linebroken, either by adding a max-width or doing something else to make it responsive to the window-size.

Comment 3

[Daniel Holbert [:dholbert]]

searchfox blame indicates that this string was added in Bug 1520324.
https://hg.mozilla.org/mozilla-central/rev/8de26a67ac5c#l21.14

Marking as a regression from that bug & CC'ing the folks involved.

Comment 4

[Punam Dahiya [:pdahiya]]

This issue should be resolved with fix of bug 1533601 in 68

Comment 5

[Ed Lee :Mardak]

Fixed in https://hg.mozilla.org/mozilla-central/rev/7a435211fa07

This should only have affected nightly users and those in the experiments.