1533601 - Home Preference Settings Improvements

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Wolasi :wolasi]

Let's bring back the settings for Top Sites and Snippets.

Requirements

• It should allow the user to enable/disable:
  • Search
  • Top Sites
  • Recommended by Pocket
  • Snippets
• All sections should be enabled by default
• We should continue to maintain the Activity Stream preferences UI separate from the Discovery Stream preferences.

Implementation Details

• Recommended by Pocket settings should no longer have a selector for number of rows
• Settings for Highlights are not included because that section has not been added to Home/New Tab yet
• Section titles should match those on New Tab

Defaults

• Top Sites selected with 1 row selected
• Recommended by Pocket selected, Sponsored Stories selected
• Snippets selected

Behavior

• Top Sites and Snippets settings should behave as before
• Deselect Recommended by Pocket should hide the section on Home/New Tab
  – Reselecting Recommended by Pocket should display the section on Home/New Tab
• Deselecting Sponsored Stories under Recommended by Pocket should hide SPOCs in the Recommended by Pocket on Home/New Tab
  – Reselecting Sponsored Stories under Recommended by Pocket should display SPOCS in the Recommended by Pocket on Home/New Tab

Spec
https://www.figma.com/file/0xZkmT86rSXbGRB4eIvrn0ts/New-Tab-Spec-for-Fx-v68?node-id=69%3A1

Comment 1

[Kate Hudson :k88hudson]

Can you edit this to say Highlights instead of snippets

Comment 2

[Ed Lee :Mardak]

Bug 1528400 will fix the top sites portion. There might be other bugs to split up getting highlights and other prefs working.

Comment 3

[Wolasi :wolasi]

It should be Snippets since we haven't implemented the Highlights section yet.

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4886

Comment 6

[Punam Dahiya [:pdahiya]]

Fix of this bug should resolve issue in bug 1529141

Comment 7

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/7a435211fa07

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this issue with the latest Firefox Nightly (68.0a1 Build ID - 20190415094551) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the sections can be enabled/disabled from the "about:preferences#home" and the rows selector is available only for the "Top Sites" section.