1529190 - InsertTagCommand::DoCommandParams() does not aware of non-ASCII URL

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

InsertTagCommand::DoCommandParams() inserts given URL to href of <a> or src of <img>. However, it treats the given URL includes only ASCII characters. Therefore, we cannot insert URL including non-ASCII characters with execCommand("createLink") nor execCommand("insertImage").

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1529190 - Make `execCommand("createLink")` and `execCommand("insertImage")` aware of URL including non-ASCII characters

InsertTagCommand::DoCommandParams() inserts given URL to href of <a> or
src of <img>. However, it treats the given URL includes only ASCII
characters. Therefore, we cannot insert URL including non-ASCII characters
with execCommand("createLink") nor execCommand("insertImage").

This patch makes the method assume that the 3rd parameter may include non-ASCII
characters.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdc5726d5a27
Make `execCommand("createLink")` and `execCommand("insertImage")` aware of URL including non-ASCII characters r=m_kato

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/fdc5726d5a27

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15573 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged