InsertTagCommand::DoCommandParams() does not aware of non-ASCII URL

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P2
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

({parity-chrome, parity-edge})

65 Branch
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

InsertTagCommand::DoCommandParams() inserts given URL to href of <a> or src of <img>. However, it treats the given URL includes only ASCII characters. Therefore, we cannot insert URL including non-ASCII characters with execCommand("createLink") nor execCommand("insertImage").

InsertTagCommand::DoCommandParams() inserts given URL to href of <a> or
src of <img>. However, it treats the given URL includes only ASCII
characters. Therefore, we cannot insert URL including non-ASCII characters
with execCommand("createLink") nor execCommand("insertImage").

This patch makes the method assume that the 3rd parameter may include non-ASCII
characters.

Priority: -- → P2

Comment 2

3 months ago
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/fdc5726d5a27
Make `execCommand("createLink")` and `execCommand("insertImage")` aware of URL including non-ASCII characters r=m_kato

Comment 3

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15573 for changes under testing/web-platform/tests
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.