Closed
Bug 1530250
Opened 6 years ago
Closed 6 years ago
InsertTagCommand::DoCommandParams() should check the result of nsCommandParams::GetString()
Categories
(Core :: DOM: Editor, defect)
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox65 | --- | unaffected |
| firefox66 | --- | unaffected |
| firefox67 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
When I modified the patch for bug 1529190, I removed the result check of nsICommandParams::GetString() accidentally and it was detected by static-analysis bot at landing. So, we should fix it with a follow up patch.
|
Assignee | |
Comment 1•6 years ago
|
||
Accidentally, I removed the check in the previous landing (bug 1529190). This
patch restores it.
|
|
Assignee | |
Comment 2•6 years ago
|
||
Accidentally, I removed the check in the previous landing (bug 1529190). This
patch restores it.
|
||
Updated•6 years ago
|
Attachment #9046655 -
Attachment is obsolete: true
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/d954c8365626
Make InsertTagCommand::DoCommandParams() check result of nsCommandParams::GetString() r=m_kato
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
|
||
Updated•6 years ago
|
status-firefox65:
--- → unaffected
status-firefox66:
--- → unaffected
status-firefox-esr60:
--- → unaffected
|
||
Updated•6 years ago
|
Type: enhancement → defect
You need to log in
before you can comment on or make changes to this bug.
Description
•