1529305 - Add nasm in MinGW32/64 and the L10n for Windows 2012 opt 32/64

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, enhancement)

Description

[Alex Chronopoulos [:achronop]]

In order to enable ASM dav1d build on windows we are missing MinGW32/64 and the L10n for Windows 2012 opt 32/64 as described in [1].

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1521062#c3

Comment 1

[Thomas Daede [:TD-Linux]]

I think at least l10n should be fixed by a rebase.

Comment 2

[Alex Chronopoulos [:achronop]]

In [1] is a latest try. I don't see a l10s build running at all. I haven't done anything differently. In any case if those runs have been removed only MinGW runs are the remaining failure.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad81a2977c43088285c812290cce5c099091b93b

Comment 3

[Thomas Daede [:TD-Linux]]

Attachment: Bug 1529305 - Fix mingw-gcc nasm target format.

Comment 4

[Alex Chronopoulos [:achronop]]

This try run includes the patch in comment 3 on the top of the patches that enable ASM dav1d builds on windows from Bug 1521062.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d4698421d6a19067560bcb193d8005c46e12689

Comment 5

[Thomas Daede [:TD-Linux]]

Attachment: Bug 1529305 - Add NASM env var to win64-plain/opt.

This one doesn't inherit the common mozconfig.nasm file.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ec03a6f1ca5
Add NASM env var to win64-plain/opt. r=dmajor

Comment 7

[Thomas Daede [:TD-Linux]]

Attachment: Bug 1529305 - Emit cv8 debug info with nasm even on mingw.

Comment 8

[Thomas Daede [:TD-Linux]]

I made an alternate attachment. I had misunderstood mingw as using elf for .o, but it uses COFF, and nasm only supports cv8 debug info for that. I have no idea how the yasm manages to work, it's either stuffing dwarf in COFF or not being built at all for mingw.

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8ec03a6f1ca5

Comment 10

[Alex Chronopoulos [:achronop]]

There is a second patch in the queue that needs to be landed. We can close it then.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/512b63ef9f71
Emit cv8 debug info with nasm even on mingw. r=firefox-build-system-reviewers,mshal

Comment 12

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/512b63ef9f71

Comment 13

[Matthew N. [:MattN]]

(In reply to Alex Chronopoulos [:achronop] from comment #10)

There is a second patch in the queue that needs to be landed. We can close it then.

Looks like both landed now, right? Can we resolve this?

Comment 14

[Alex Chronopoulos [:achronop]]

Yeah, everything is there now, thank you very much.