1529455 - moz-phab: "Bug #" in revision summary was changed to "bug #" while pushing an update

Status: REOPENED

(Conduit :: moz-phab, defect, P3)

Description

[Karl Tomlinson (:karlt)]

+++ This bug was initially created as a clone of Bug #1528874 +++

e.g. the case change at https://phabricator.services.mozilla.com/D20605#552165

Comment 1

[:glob ✱]

i not sure how could have happened; we always use "Bug", never "bug": https://github.com/mozilla-conduit/review/blob/99d2a0086c54dcd61c9d43bebf0eea82c0e85822/moz-phab#L1900

i was unable to replicate this issue with my testing, and a quick look around phabricator doesn't show any other titles being updated in this way.

can you please provide the full output of the moz-phab command that updated the revision?

Comment 2

[Karl Tomlinson (:karlt)]

I suspect the usual transformations (see bug 1528874 et al) are not being performed on updates. That's probably a good thing because it avoids changing changeset hashes. The bug is probably that the original revision was given "Bug #" in its title.

The STR might explain why this inconsistency shows up as a change to the revision title:

1. Transplant changeset from development repository to review submission repository.

2. Submit with moz-phab from the review repository.

   This produced https://phabricator.services.mozilla.com/D20605#552108

3. Amend the original changeset in the development repository, adding Differential Revision: https://phabricator.services.mozilla.com/D20605 to the commit message.

4. Transplant amended changeset from development repository to review submission repository, onto the same parent revision as in step 1.

5. Submit with moz-phab from the review repository.

% moz-phab submit .
Submitting 1 commit:
(D20274) 460530:0218e61f82ef Bug 1519562 send AudioParamDescriptors from registerProcessor() to AudioContext r?padenot
0218e61f82ef is based off non-public commit eeb6643527a0
Warning: found 161 untracked files (will not be submitted for review):
Submit to Phabricator (YES/No/Always)? 

Updating revision D20274:
460530:0218e61f82ef Bug 1519562 send AudioParamDescriptors from registerProcessor() to AudioContext r?padenot
Linting...
No lint engine configured for this project.
Running unit tests...
No unit test engine is configured for this project.
 SKIP STAGING  Phabricator does not support staging areas for this repository.
Updated an existing Differential revision:
        Revision URI: https://phabricator.services.mozilla.com/D20274

Included changes:
  M       dom/media/webaudio/AudioContext.cpp
  M       dom/media/webaudio/AudioContext.h
  M       dom/media/webaudio/AudioWorkletGlobalScope.cpp
  M       dom/media/webaudio/AudioWorkletImpl.h

Completed
(D20274) 460531:feb8f17a26ec Bug 1519562 send AudioParamDescriptors from registerProcessor() to AudioContext r?padenot
-> https://phabricator.services.mozilla.com/D20274

This produced https://phabricator.services.mozilla.com/D20605#552163

Comment 3

[Karl Tomlinson (:karlt)]

Hmm. I see moz-phab did actually modify the commit message (and change the changeset hash of the amended changeset).

This was before moz-phab submit:

@  changeset:   460530:0218e61f82ef
|  tag:         tip
|  parent:      460305:eeb6643527a0
|  user:        Karl Tomlinson <[e-mail]>
|  date:        Fri Feb 15 19:45:09 2019 +1300
|  files:       dom/media/webaudio/AudioContext.cpp dom/media/webaudio/AudioContext.h dom/media/webaudio/AudioWorkletGlobalScope.cpp dom/media/webaudio/AudioWorkletImpl.h
|  description:
|  bug 1519562 send AudioParamDescriptors from registerProcessor() to AudioContext r?padenot
|
|  Differential Revision: https://phabricator.services.mozilla.com/D20274

This was after:

@  changeset:   460531:feb8f17a26ec
|  tag:         tip
|  parent:      460305:eeb6643527a0
|  user:        Karl Tomlinson <[e-mail]>
|  date:        Fri Feb 15 19:45:09 2019 +1300
|  files:       dom/media/webaudio/AudioContext.cpp dom/media/webaudio/AudioContext.h dom/media/webaudio/AudioWorkletGlobalScope.cpp dom/media/webaudio/AudioWorkletImpl.h
|  description:
|  Bug 1519562 send AudioParamDescriptors from registerProcessor() to AudioContext r?padenot
|
|  Differential Revision: https://phabricator.services.mozilla.com/D20274

Comment 4

[Karl Tomlinson (:karlt)]

Sorry the output in comment 2 and 3 is for D20274, but the process and results are similar to D20605.

Comment 5

[Steven MacLeod [:smacleod]]

Unable to reproduce this at this time. If you have a stable reproduction please re-open.

Comment 6

[Karl Tomlinson (:karlt)]

Still reproduces with workflow in comment 2: https://phabricator.services.mozilla.com/D24672?vs=80479&id=80852#726021

Check that first line of comment message has uncapitalized "bug" before step 5.

Comment 7

[Steven MacLeod [:smacleod]]

Oh, what was not clear to me at all before is :karlt is starting with "bug", rather than "Bug", in his commit locally. moz-phab is changing this to be capitalized for the initial submission, but not doing the same on updates. This manifests as a change from "Bug" to "bug" in Phabricator on update.

I have not attempted to reproduce, but I think we were misinterpreting the report before.