1529506 - Show a banner on the web UI that allows you to upload patches that a patch cannot be landed with lando

Status: RESOLVED FIXED

(Conduit :: Phabricator, enhancement)

Description

[Jorg K (CEST = GMT+2)]

I added a simple patch/diff in bug 1529202 and when I or the sheriffs came to land it, I got:
"This diff does not have the proper author information uploaded to Phabricator"

FAQ say:
The revision was created via the Phabricator Web UI or via an unsupported client.

Yes, it was uploaded via
https://phabricator.services.mozilla.com/differential/diff/create/

So is that meant to work? Can you please make it work.

Comment 1

[:glob ✱]

unfortunately the web ui doesn't collect all the information we need.

please use moz-phab, arc, or another phabricator client to submit patches if you want them landable with lando.

i'll raise the issue of why the web ui is still available in our next team meeting.

Comment 2

[Jorg K (CEST = GMT+2)]

As I mentioned before, to set up Arcanist on three Windows (Thunderbird) development machines is prohibitively laborious (https://moz-conduit.readthedocs.io/en/latest/arcanist-windows.html) to submit and land M-C patches occasionally.

I guess if you remove the not-fully-functioning web UI altogether, you will cut off a whole lot more occasional contributors. Everyone could create a diff or HG patch, but to set up the new environment will be a huge hurdle for some/most people, IMHO.

Comment 3

[:glob ✱]

(In reply to Jorg K (GMT+1) from comment #2)

As I mentioned before, to set up Arcanist on three Windows (Thunderbird) development machines is prohibitively laborious (https://moz-conduit.readthedocs.io/en/latest/arcanist-windows.html) to submit and land M-C patches occasionally.

i agree that the setup, particularly on windows, has some pain points.

we're working on taking arc out of the equation which simplifies things a lot, with a stop-gap measure that makes moz-phab automatically clone the arc repo and friends.

this bug is about uploading via the web UI, and we need to either support it fully or hide it until it can be fully supported (i know that it likely won't be possible until there's IAM linkage between LDAP and BMO).

Comment 4

[:glob ✱]

we discussed this and the issue is indeed the linking between BMO and LDAP users.

there's a long running project to make this linkage happen, however that isn't ready quite yet (it's part of the new phonebook).

in order to prevent issues where patches are uploaded via the web form, reviewed, but then are unable to be landed we're going to disable that form.

once the BMO/LDAP linkage is in place we'll re-enable it.

Comment 5

[:glob ✱]

after more discussion we'll instead show a banner on the web form, and on the revisions, to indicate that patches uploaded there cannot be landed with lando.

Comment 6

[David Lawrence [:dkl]]

Attachment: phabricator-extensions: Show a banner on the web UI that allows you to upload patches that a patch cannot be landed with lando (bug 1529506)

This patch to the Phabricator code shows a warning banner on the diff upload page stating that when using the
web UI, you will not be able to use Lando for landing of the patch(es).

Comment 7

[David Lawrence [:dkl]]

Committed to master and will be in the next Phabricator deployment.