1529510 - Implement ProcInfo on android

Status: RESOLVED FIXED

(Core :: Widget, enhancement, P1)

Description

[Tarek Ziadé (:tarek)]

see https://developer.android.com/reference/android/app/ActivityManager.RunningAppProcessInfo

Comment 1

[Tarek Ziadé (:tarek)]

Also, see how that compares to adb system memory dump

Comment 2

[Tarek Ziadé (:tarek)]

https://developer.android.com/studio/command-line/dumpsys

Comment 3

[Tarek Ziadé (:tarek)]

Source code of the dumped memory info

==> https://android.googlesource.com/platform/frameworks/base/+/donut-release2/core/jni/android_os_Debug.cpp

They are reading the /proc/[pid]/smaps file to get the info.

That file is part of the POSIX standard so I guess I can port the linux version and extend it with [smaps] info

Comment 4

[Tarek Ziadé (:tarek)]

I don't have the bandwidth right now, feel free to pick it (it should be failry easy to implement, but requires testing on several androids)

Comment 5

[David Teller [:Yoric] - still alive but not very active]

(In reply to Tarek Ziadé (:tarek) from comment #3)

Source code of the dumped memory info

==> https://android.googlesource.com/platform/frameworks/base/+/donut-release2/core/jni/android_os_Debug.cpp

They are reading the /proc/[pid]/smaps file to get the info.

That file is part of the POSIX standard so I guess I can port the linux version and extend it with [smaps] info

I have in-flight code that will use /proc/[pid]/smaps on Linux, too.

Comment 6

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1529510 - Use Linux GetProcInfo on Android;r?tarek,rbarker

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Just tested: the latest landed version of Linux GetProcInfo seems to work on (at least one version of) Android.

Trying to find out whether our CI tests do run browser_test_procinfo.js and browser_aboutprocesses.js.

Comment 8

[David Teller [:Yoric] - still alive but not very active]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c3256a43bbec1847ee73faaedf8d9205ae5aec7f&selectedTaskRun=MXy0p2tsSfG7521M2zusGQ.0

Comment 9

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1529510 - Move ProcInfo to processtoolsservice;r?aklotz,tarek

With this change, we expose ProcInfo to Android.

Note that we need to leave several empty ProcInfo.{cpp, mm} files lying around as removing them triggers unified build errors.

Comment 10

[David Teller [:Yoric] - still alive but not very active]

I'll try and find out how I can remove ProcInfo.cpp without triggering the unified build errors as a second patch.

Comment 11

[David Teller [:Yoric] - still alive but not very active]

Looks like I won't be able to push to try today because of bug 1674346.

Given that today is my last day at Mozilla, Tarek, can I reassign this bug to you?

Comment 12

[Tarek Ziadé (:tarek)]

yes, thx

Comment 13

[Tarek Ziadé (:tarek)]

Updated, if you want to check it out Aaron

Comment 14

[(No longer employed by Mozilla) Aaron Klotz]

r+

Comment 15

[(No longer employed by Mozilla) Aaron Klotz]

Can we land this? I landed e10s-multi on Android on Monday and we'd really like to have about:processes available...

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8da02cb71d6
Move ProcInfo to processtoolsservice;r=aklotz,mstange

Comment 17

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a8da02cb71d6