1631945 - Add API to junit test harness that enables tests to query for all web content pids

Status: RESOLVED FIXED

(GeckoView Graveyard :: Sandboxing, enhancement, P1)

Description

[(No longer employed by Mozilla) Aaron Klotz]

This is kind of unfortunate, but a consequence of the fact that we have overloaded ContentParent to be used for multiple types of content.

In GeckoView we'd like to know whether we're being asked to launch a content process for the extension process or web content. Unfortunately, by the time a content process launch request reaches GeckoView code, we do not have that information.

It would be nice if we could have some mechanism to pass ContentParent::mRemoteType into GeckoChildProcessHost as a "subtype" so that GeckoView could route the request to create an extension process slightly differently from a normal content process.

The primary issue that we have is that many of our unit tests need to terminate multiple web content processes, but ATM we don't really have a way to distinguish between web and extension content. If there is an alternative way to ascertain this information, I'm all ears, but otherwise we will want to make this change sooner rather than later.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Hmmm, looks like I can probably stuff this info into the aExtraOpts argument to GeckoChildProcessHost::AsyncLaunch, so I'll move this into our component.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1631945: Add a dedicated service to GeckoView for hosting the extension process; r=agi!, r=nika!

• From Gecko we pass ContentParent::mRemoteType into GeckoProcessManager for
  both process launch and process termination;
• We add the extension process as its own service;
• We add the ContentProcessSubType enumeration to represent the various
  content process subtypes;
• We add GeckoServiceType that resolves a
  (GeckoProcessType, ContentProcessSubType) tuple into a service name;
• We convert GeckoProcessManager and ServiceAllocator to work with
  GeckoServiceType instead of GeckoProcessType.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

This is less important now that the extension process is disabled across the board.

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

I think we were planning on bumping this from 78 during sprint planning, but that never made it into the bug.

Comment 5

[Chris Peterson [:cpeterson]]

Tracking this bug for Android Fission milestone M2 (pass tests with Fission enabled).

Comment 6

[[:owlish] 🦉 PST]

Attachment: Bug 1631945 - Add API to junit test harness that enables tests to query for all web content pids

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f55f0f826ef6
Add API to junit test harness that enables tests to query for all web content pids r=geckoview-reviewers,aklotz

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f55f0f826ef6

Comment 9

[Chris Peterson [:cpeterson]]

Moving isolated process bugs to the new GeckoView::Sandboxing component.