1529697 - Crash in [@ mozilla::gl::SharedSurface_SurfaceTexture::LockProdImpl]

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-eefb4187-7e5c-41c5-ba17-e821a0190221.

New Fennec nightly crash which started in 20190221093143: https://bit.ly/2XinRh9. 10 crashes/8 installations so far.

Possible regression window based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bf3951daded0b4fefd0fc81ee22ce5d536df2099&tochange=2acb22602c60a2380cdd978d6bbdc55ba314604b

Bug 1529322? ni on :agi

Top 10 frames of crashing thread:

0 libxul.so mozilla::gl::SharedSurface_SurfaceTexture::LockProdImpl gfx/gl/SharedSurfaceEGL.cpp:200
1 libxul.so mozilla::gl::SharedSurface::LockProd gfx/gl/SharedSurface.cpp:210
2 libxul.so mozilla::gl::GLContext::Readback gfx/gl/GLContext.cpp:2263
3 libxul.so mozilla::layers::CopyableCanvasRenderer::ReadbackSurface gfx/layers/CopyableCanvasRenderer.cpp:160
4 libxul.so mozilla::layers::BasicCanvasLayer::Paint gfx/layers/basic/BasicCanvasLayer.cpp:41
5 libxul.so mozilla::layers::BasicLayerManager::PaintSelfOrChildren gfx/layers/basic/BasicLayerManager.cpp:691
6 libxul.so mozilla::layers::BasicLayerManager::PaintLayer gfx/layers/basic/BasicLayerManager.cpp
7 libxul.so mozilla::layers::BasicLayerManager::PaintSelfOrChildren gfx/layers/basic/BasicLayerManager.cpp:711
8 libxul.so mozilla::layers::BasicLayerManager::PaintLayer gfx/layers/basic/BasicLayerManager.cpp
9 libxul.so mozilla::layers::BasicLayerManager::EndTransactionInternal gfx/layers/basic/BasicLayerManager.cpp:605

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Yeah that's definitely caused by my change. Looks like that crash has been there for a while it just didn't occur in Fennec because it doesn't have e10s. rbarker do you think we should fix this before enabling SurfaceTexture?

Comment 2

[Randall Barker [:rbarker]]

We had a lot of problems with mSurface->GetAvailable() in FxR. Must not have caught all the edge cases. Since e10s is already using SharedSurface we probably want this fixed as soon as possible since I assume Fenix will hit this (if it isn't already). But I would turn it off for Fennec since it doesn't really fix anything there.

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Sounds good. I'll revert my change.

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/1657fe18be9bc445c7838e3b4e93a9bfc4f85e7f

Comment 5

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/mozilla-central/rev/1657fe18be9bc445c7838e3b4e93a9bfc4f85e7f