1529763 - Port Bug 1529252: Remove the 2 from the various version to create a channel within nsIIOService.idl

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Jorg K (CEST = GMT+2)]

As far as I can see, it's mostly NewChannelFromURI2 which loses the "2":

https://hg.mozilla.org/mozilla-central/rev/fd1d0afce253

One occurrence in C++ code, so that gives bustage, and many more in JS code.

Patch coming.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1529763-NewChannelFromURI2.patch

I changed the trickery in gdataRequest.jsm, I think we can drop compatibility with Lightning 4.2 and older. Besides, it would still work since passing more parameters shouldn't hurt.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/810588b5151e
Port bug 1529252: s/NewChannelFromURI2/NewChannelFromURI/. rs=bustage-fix

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9045791 [details] [diff] [review]
1529763-NewChannelFromURI2.patch

Review of attachment 9045791 [details] [diff] [review]:
-----------------------------------------------------------------

Nothing too complicated here. :)

::: mail/test/resources/mozmill/mozmill/extension/content/stdlib/securable-module.jsm
@@ +307,3 @@
>                                              null,
>                                              Services.scriptSecurityManager.getSystemPrincipal(),
>                                              null,

Please fix this awful indent.

::: suite/mailnews/components/addrbook/content/abCommon.js
@@ +716,3 @@
>                                           null,
>                                           Services.scriptSecurityManager.getSystemPrincipal(),
>                                           null,

And this one.

Comment 4

[Jorg K (CEST = GMT+2)]

Actually, no. One is MozMill and one is suite/. And the "awful" indent came in handy since I didn't have to change it ;-)

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1529763-newChannel2.patch

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9c16e1ffb7fe
Port bug 1529252: s/Services.io.newChannel2/Services.io.newChannel/. rs=bustage-fix