Update builders to rustc 1.33
Categories
(Firefox Build System :: General, enhancement)
Tracking
(firefox68 fixed)
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: chmanchester, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
The release date for rustc 1.33 is February 28th.
|
||
Comment 1•5 years ago
|
||
I think we shouldn't do this until bug 1521734 is fixed so that bug 1521249 can land without regressing perf on 32-bit ARM Android.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/d3f27592a382 Upgrade builders to rust 1.33. r=froydnj
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/334d8f9c9995 Fix Android webrender bustages. r=glandium
|
||
Comment 5•5 years ago
|
||
Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=236264911&repo=autoland&lineNumber=2370
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=236269345&repo=autoland&lineNumber=2328
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=236273012&repo=autoland&lineNumber=2325
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=236262012&repo=autoland&lineNumber=2217
Backout link: https://hg.mozilla.org/integration/autoland/rev/bc572aee49b6e53346fc45fecbf7f136f980f541
|
|
Assignee | |
Comment 6•5 years ago
|
||
Interestingly enough, the test is green if I backout bug 1521734 in a try.
... this is going to be interesting.
|
|
Assignee | |
Comment 7•5 years ago
|
||
|
||
Comment 9•5 years ago
|
||
Thanks for the ping, it had slipped through the cracks.
|
||
Comment 10•5 years ago
|
||
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/2602ed5c149c Disable test_profile_worker* on ARM Android. r=mstange https://hg.mozilla.org/integration/autoland/rev/50447a9c4347 Upgrade builders to rust 1.33. r=froydnj
|
||
Comment 11•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2602ed5c149c
https://hg.mozilla.org/mozilla-central/rev/50447a9c4347
|
|
||
Comment 12•5 years ago
|
||
| bugherder | ||
|
||
Comment 13•5 years ago
|
||
status-firefox68: --- → fixed
Need for ESR60
|
|
||
Comment 14•5 years ago
|
||
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/ae7fce4e9815 No bug - Add linux64-rust-1.32 toolchain (likely needed for bug 1529774). rs=bustage-fix
|
|
||
Comment 15•5 years ago
|
||
(In reply to Alzimzim from comment #13)
Need for ESR60
https://wiki.mozilla.org/Rust_Update_Policy_for_Firefox says:
We expect esr releases will stay on the same minimum Rust version, so backporting security fixes may require Rust compatibility work too.
If we updated ESR to Rust 1.33, we'd need to take bug 1521249 into ESR (or regress performance). That would break compat with the version of Rust that ESR60 shipped with. Per above, downstream distros should be able to expect ESR point releases not to change the Rust requirement.
(OTOH, if a distro wants to roll Rust forward and ship Firefox ESR without regressing perf, they need to apply the ESR patches from bug 1521249.)
It doesn't seem worthwhile to disturb ESR considering that 68 is going to be the next ESR anyway.
|
|
||
Comment 16•5 years ago
|
||
In the office installed rust 1.33 + esr60.
Support esr60 exists to 2019-09-03
https://wiki.mozilla.org/Release_Management/Calendar
|
|
||
Comment 17•5 years ago
|
||
(In reply to Alzimzim from comment #16)
Support esr60 exists to 2019-09-03
I`m sorry
2019-08-26
|
|
||
Comment 18•5 years ago
|
||
(In reply to Alzimzim from comment #16)
In the office installed rust 1.33 + esr60.
--enable-rust-simd breaks with the Rust 1.33 + ESR60 combination.
|
|
||
Comment 19•5 years ago
|
||
(In reply to Henri Sivonen (:hsivonen) from comment #18)
(In reply to Alzimzim from comment #16)
In the office installed rust 1.33 + esr60.
--enable-rust-simdbreaks with the Rust 1.33 + ESR60 combination.
--- a/toolkit/moz.configure 2019-03-13 22:33:54.000000000 +0100
+++ b/toolkit/moz.configure 2019-03-19 10:18:15.769460797 +0100
@@ -856,9 +856,9 @@
# x86 and x86_64. It's meant to work on 32-bit ARM, too,
# but currently does not.
if target.cpu in ('aarch64', 'x86', 'x86_64') and value:
-
if rustc_info and rustc_info.version >= Version('1.33.0'): -
die('--enable-rust-simd does not work with Rust 1.33 or later. ' -
'See https://bugzilla.mozilla.org/show_bug.cgi?id=1521249 .')
-
#if rustc_info and rustc_info.version >= Version('1.33.0'): -
# die('--enable-rust-simd does not work with Rust 1.33 or later. ' -
# 'See https://bugzilla.mozilla.org/show_bug.cgi?id=1521249 .') return True
set_config('MOZ_RUST_SIMD', rust_simd)
|
|
||
Comment 20•5 years ago
|
||
Description
•