Closed Bug 1529946 Opened 2 years ago Closed 2 years ago

Don't repeatedly prompt to save the same username and password combination in the same document

Categories

(Toolkit :: Password Manager, defect, P2)

defect

Tracking

()

VERIFIED FIXED
mozilla67
Tracking Status
firefox67 --- verified
firefox68 --- verified

People

(Reporter: MattN, Assigned: prathiksha)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

We shouldn't repeatedly prompt to save the save username and password combination for the same FormLike as the user had a chance to save on the first submission.

This can occur in single-page apps where pushState/replaceState triggers our doorhanger but the login fields don't get removed from the page, sometimes just hidden.

There is already an implementation at https://phabricator.services.mozilla.com/D21378 which just needs tests to land.

Note that I'm not working on this bug but just attached my patch which someone can write tests for.

The test for this would need to be for login fields not inside a <form> (since this blocks