1530029 - Pressing enter on the autocomplete footer should open the password manager dialog

Status: VERIFIED FIXED

(Toolkit :: Password Manager, enhancement, P2)

Description

[:prathiksha]

We should also note to pref on the signon.showAutoCompleteFooter that is being added in Bug 1189618, by default on desktop, after this change.

Comment 1

[Matthew N. [:MattN]]

We will also enable the feature by default on Desktop only as part of this bug.

Comment 2

[:prathiksha]

Attachment: Bug 1530029 - Pressing enter on the autocomplete footer should open the password manager dialog. r?MattN

Pressing enter on the autocomplete footer should open the password manager dialog.

Comment 3

[:prathiksha]

Attachment: Bug 1530029 - Pressing enter on the autocomplete footer should open the password manager dialog. r?MattN

Comment 4

[:prathiksha]

Attachment: Bug 1530029 - Turn on the signon.showAutoCompleteFooter pref. r?MattN

Depends on D22424

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21d6040d2bd8
Pressing enter on the autocomplete footer should open the password manager dialog. r=MattN
https://hg.mozilla.org/integration/autoland/rev/ad613d1154eb
Turn on the signon.showAutoCompleteFooter pref. r=MattN

Comment 6

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1530029) for Mochitest failues in toolkit/components/passwordmgr/test/mochitest/test_autocomplete_https_upgrade.html

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=232313585&repo=autoland&lineNumber=30825

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ad613d1154eb910dbceeac5dff7585a1ce8d0c52

Backout:
https://hg.mozilla.org/integration/autoland/rev/4e4a50b917e6cff9bb646e0808bd78cd70e4abaf

Comment 7

[:prathiksha]

Attachment: Bug 1530029 - Fix tests that use checkArrayValues to also check for the autocomplete footer in password manager tests. r?MattN

Depends on D22425

Comment 8

[:prathiksha]

Attachment: Bug 1530029 - Fix tests that use checkArrayValues to also check for the autocomplete footer in password manager tests. r?MattN

Depends on D22425

Comment 9

[Phabricator Automation]

Comment on attachment 9049034 [details]
Bug 1530029 - Turn on the signon.showAutoCompleteFooter pref. r?MattN

Revision D22425 was moved to bug 1534442. Setting attachment 9049034 [details] to obsolete.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd7db47ad078
Pressing enter on the autocomplete footer should open the password manager dialog. r=MattN
https://hg.mozilla.org/integration/autoland/rev/89679dcecb8a
Fix tests that use checkArrayValues to also check for the autocomplete footer in password manager tests. r=MattN

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/bd7db47ad078
https://hg.mozilla.org/mozilla-central/rev/89679dcecb8a

Comment 12

[Matthew N. [:MattN]]

Hi liviu, would you (or someone else) be able to verify this bug since you verified bug 1189618?

Thanks

Comment 13

[Liviu Seplecan]

Hi Matthew, Please provide me more details in order to verify this issue, any TC or scenario.Thanks

Comment 14

[Timea Cernea [:tbabos][inactive]]

Stealing this from Liviu..
Verified - Fixed on latest Nightly 67.0a1 (2019-03-13) (64-bit) on Windows 10, Mac OS 10.13 and Ubuntu 16.04.
Selecting and pressing enter on the "View Saved Logins" footer will open the password manager.