Closed Bug 1530029 Opened 2 years ago Closed 2 years ago

Pressing enter on the autocomplete footer should open the password manager dialog

Categories

(Toolkit :: Password Manager, enhancement, P2)

enhancement

Tracking

()

VERIFIED FIXED
mozilla67
Tracking Status
firefox67 --- verified

People

(Reporter: prathiksha, Assigned: prathiksha)

References

Details

Attachments

(2 files, 3 obsolete files)

We should also note to pref on the signon.showAutoCompleteFooter that is being added in Bug 1189618, by default on desktop, after this change.

Assignee: nobody → prathikshaprasadsuman
Blocks: 1189618
Status: NEW → ASSIGNED

We will also enable the feature by default on Desktop only as part of this bug.

Priority: -- → P2

Pressing enter on the autocomplete footer should open the password manager dialog.

Attachment #9049033 - Attachment is obsolete: true
Pushed by prathikshaprasadsuman@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/21d6040d2bd8
Pressing enter on the autocomplete footer should open the password manager dialog. r=MattN
https://hg.mozilla.org/integration/autoland/rev/ad613d1154eb
Turn on the signon.showAutoCompleteFooter pref. r=MattN
Flags: needinfo?(prathikshaprasadsuman)
Attachment #9049680 - Attachment is obsolete: true
Attachment #9049680 - Attachment is obsolete: false
Attachment #9050091 - Attachment is obsolete: true

Comment on attachment 9049034 [details]
Bug 1530029 - Turn on the signon.showAutoCompleteFooter pref. r?MattN

Revision D22425 was moved to bug 1534442. Setting attachment 9049034 [details] to obsolete.

Attachment #9049034 - Attachment is obsolete: true
Pushed by prathikshaprasadsuman@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bd7db47ad078
Pressing enter on the autocomplete footer should open the password manager dialog. r=MattN
https://hg.mozilla.org/integration/autoland/rev/89679dcecb8a
Fix tests that use checkArrayValues to also check for the autocomplete footer in password manager tests. r=MattN
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Flags: needinfo?(prathikshaprasadsuman) → qe-verify+

Hi liviu, would you (or someone else) be able to verify this bug since you verified bug 1189618?

Thanks

Flags: needinfo?(liviu.seplecan)

Hi Matthew, Please provide me more details in order to verify this issue, any TC or scenario.Thanks

Flags: needinfo?(liviu.seplecan)

Stealing this from Liviu..
Verified - Fixed on latest Nightly 67.0a1 (2019-03-13) (64-bit) on Windows 10, Mac OS 10.13 and Ubuntu 16.04.
Selecting and pressing enter on the "View Saved Logins" footer will open the password manager.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.