1534442 - Turn on 'View Saved Logins' autocomplete footer by default on desktop

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect, P1)

Description

[:prathiksha]

[Tracking Requested - why for this release]: New feature needed to support a Lockbox desktop extension launch.

prefName - signon.showAutoCompleteFooter

Comment 1

[:prathiksha]

Attachment: Bug 1534442 - Turn on the signon.showAutoCompleteFooter pref. r?MattN

Depends on D21603

Comment 2

[Pascal Chevrel:pascalc]

Tracking for 67 to keep under my radar. Note that this is going against our soft code freeze rules, we shouldn't activate new features that didn't get exposed during the nightly cycle the week before the final merge to Beta:
https://wiki.mozilla.org/Release_Management/Release_Process#Nightly_soft_code_freeze

This is also a new feature not tracked in our Trello board for any release and this Lockbox desktop extension isn't listed either as an extention shipping in the "2019 H1 Off-Train Projects".

Prathiska was there a PI request to get this feature QAed?

Comment 3

[Matthew N. [:MattN]]

(In reply to Pascal Chevrel:pascalc from comment #2)

Tracking for 67 to keep under my radar. Note that this is going against our soft code freeze rules, we shouldn't activate new features that didn't get exposed during the nightly cycle the week before the final merge to Beta:
https://wiki.mozilla.org/Release_Management/Release_Process#Nightly_soft_code_freeze

No, it's not going against the rules. There was no plan to land this during the soft code freeze, that's a bad assumption on your part. See https://phabricator.services.mozilla.com/D22425#645416

This is also a new feature not tracked in our Trello board for any release and this Lockbox desktop extension isn't listed either as an extention shipping in the "2019 H1 Off-Train Projects".

I updated the card at https://trello.com/c/pZMDSciK/349-lockbox-desktop-extension. IIUC, Marnie just started getting involved in Lockbox so the cards weren't in order yet.

Prathiska was there a PI request to get this feature QAed?

No, since this is just adding a row to existing UI (working like the Form Autofill one), it didn't seem like something that needed a whole PI request.

Comment 4

[Matthew N. [:MattN]]

(In reply to Pascal Chevrel:pascalc from comment #2)

Prathiska was there a PI request to get this feature QAed?

The initial landing was verified in the bug this blocks. I've asked for verification in the one follow-up (bug 1530029). I've also filed a PI Request now.

I talked with Ritu and she is fine with this landing during the soft code freeze (I was originally going to request uplift after) since this is such low risk. See bug 1534447 comment 4.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4556fb6dc667
Turn on the signon.showAutoCompleteFooter pref. r=MattN

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/4556fb6dc667

Comment 7

[Timea Cernea [:tbabos][inactive]]

Verified - Fixed on latest Nightly on Windows 7/10 x64, Mac OS 10.13 and Ubuntu 16.04.
The pref is turned on by default.

Comment 8

[Matthew N. [:MattN]]

Comment on attachment 9050131 [details]
Bug 1534442 - Turn on the signon.showAutoCompleteFooter pref. r?MattN

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1189618
• User impact if declined: Users will not have easy access to related saved logins in the context of the page. This new entry point will help support the Lockbox desktop extension launching in June.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: QE has been verifying the various bugs related to the feature
• List of other uplifts needed: Bug 1538285
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The feature has been enabled on Nightly for 10 days. I talked with Ritu and she was even fine with this landing during the soft code freeze (I was originally going to request uplift after) since this is such low risk. See bug 1534447 comment 4 for discussion. Potential issues would likely be annoyance ones, not crashes.
• String changes made/needed: None

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9050131 [details]
Bug 1534442 - Turn on the signon.showAutoCompleteFooter pref. r?MattN

Uplift approved for 67 beta 7, thanks.

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ab24bd3fb3e7

Comment 11

[Rares Doghi, Desktop QA]

Hi, this issue is verified as fixed in Firefox Beta 67.0b7 - The signon.showAutoCompleteFooter = true by default. I will mark this issue accordingly