1530107 - Crash in [@ mozilla::PeerConnectionImpl::PeerConnectionImpl]

Status: VERIFIED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Calixte Denizet (:calixte)]

This bug is for crash report bp-c0d46dd5-e574-42d4-85f0-508c70190223.

Top 10 frames of crashing thread:

0 libxul.so mozilla::PeerConnectionImpl::PeerConnectionImpl media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:331
1 libxul.so mozilla::PeerConnectionImpl::Constructor media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:240
2 libxul.so mozilla::dom::PeerConnectionImpl_Binding::_constructor dom/bindings/PeerConnectionImplBinding.cpp:2116
3 libxul.so xpc::DOMXrayTraits::construct js/xpconnect/wrappers/XrayWrapper.cpp:1779
4 libxul.so js::Proxy::construct js/src/proxy/Proxy.cpp:520
5 libxul.so InternalConstruct js/src/vm/Interpreter.cpp:643
6 libxul.so Interpret js/src/vm/Interpreter.cpp:676
7 libxul.so js::RunScript js/src/vm/Interpreter.cpp:420
8 libxul.so js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:560
9 libxul.so JS::Call js/src/vm/Interpreter.cpp:587

There are 214 crashes (from 70 installations) in nightly 67 with buildid 20190223041557. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1521879.

[1] https://hg.mozilla.org/mozilla-central/rev?node=d4004105a04a

Comment 1

[Calixte Denizet (:calixte)]

I can easily reproduce it:

• open "New Private Window"
• go to https://www.bankofamerica.com/
• crash

Comment 2

[Ludovic Hirlimann [:Usul]]

Same as Calxite but with http://www.leparisien.fr/high-tech/mahjoubi-confirme-une-cyberattaque-de-grande-ampleur-ce-qu-ils-ont-reussi-a-faire-est-tres-rare-25-02-2019-8019867.php

Comment 3

[Julien Cristau [:jcristau]]

Fixed by backout in bug 1521879. I'd imagine it's fixed in the relanding.

Comment 4

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial crash using an old Nightly from 2019-02-23 on Windows 10 https://crash-stats.mozilla.org/report/index/49bfcb39-7138-4b73-8155-d257d0190423.
Verified that latest Beta 67.0b13 and latest Nightly 68.0a1 does not receive any crashes following the steps from this bug across platforms (Windows 10 64bit, Ubuntu 18.04 64bit and macOS 10.14).