1521879 - Use mtransport in a separate process, guarded by a pref

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, enhancement, P2)

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1521879 - Part 1: IPC-based MediaTransport implementation

Depends on D17272

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1521879 - Part 2: Fix include-what-you-use bugs triggered by unified compilation.

Depends on D17273

Comment 3

[Byron Campen [:bwc]]

Attachment: Bug 1521879 - Part 3: Get --disable-webrtc builds working.

Depends on D17274

Comment 4

[Byron Campen [:bwc]]

Attachment: Bug 1521879 - Part 4: Better logging for candidate gathering (was necessary to figure out parts of bug 1513059).

Depends on D17275

Comment 5

[Byron Campen [:bwc]]

Attachment: Bug 1521879 - Part 5: Get NS_NewURI working on the socket process.

Depends on D17276

Comment 6

[Byron Campen [:bwc]]

Attachment: Bug 1521879 - Part 5: Update IPC serialize/deserialize code for RTP stream stats to match what is in the dictionaries.

Depends on D17277

Comment 7

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0238e788c2cf2d5092c81febd454eccac4f6b8ef

Comment 8

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3895674c58495d19082ec2c231b37a6cc015639f

Comment 9

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=62ce98b75e46a9b871da23aaf33f9f4bf39f78af

Comment 10

[Byron Campen [:bwc]]

Attachment: Bug 1521879 - Part 6: Disable SetProxyServer for the IPC implementation until bug 1521113 is fixed or worked around.

Depends on D17278

Comment 11

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c48d03039e747272cd373d81350cbc72c3fe9fe6

Comment 12

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9658edcb2c17af4754a1f67d562db6143bbf10a

Comment 13

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=75bcb0f11d69e74329fb7c340719430d40ed60ec

Comment 14

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7203eb9429d72cf73ecd21b391b264cd57ed8db

Comment 15

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=309ffff91cdcfa25d8654af3d1ae126961554ede

Comment 16

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b4c0128f9fdced14b68bfe3401eae091bbbb67f

Comment 17

[Byron Campen [:bwc]]

Attachment: Bug 1521879 - Part 7: Create new CI jobs for media mochitests with socket process enabled.

Depends on D17560

Comment 18

[Byron Campen [:bwc]]

Attachment: Bug 1521879 - Part 8: Don't run triggered check logic on obsolete streams.

Depends on D17942

Comment 19

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=adb59d66c6a911ae85f4156c3f63bcd2a6e54dfa

Comment 20

[Byron Campen [:bwc]]

We should not try to land this (or any other webrtc signaling work) until bug 1524642 is fixed.

Comment 21

[Byron Campen [:bwc]]

Does part 7 look good now?

Comment 22

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=738902f31dc481da55af34aeb9f79e404ce5d25c

Comment 23

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ffc71a8ea0b7e54e8b72b1c376ba18808bff75b

Comment 24

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ed32c5808253d436d2013824545cebedce2faa8

Comment 25

[Byron Campen [:bwc]]

Attachment: Bug 1521879 - Part 1.1: Compensate for changes to how IPC headers are generated in the last rebase. r?mjf

Depends on D17273

Comment 26

[Andrew Halberstadt [:ahal]]

Yes, sorry for the delay!

Comment 27

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5a51ff9f502012350a49773ed5d4f28687cd6bf

Comment 28

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4b01c129d7f60a72fde3e51b0c346044bc380fd

Comment 29

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=67efd4a8a353db08281284e3536328e18e897665

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c414d82a5325
Part 1: IPC-based MediaTransport implementation r=mjf
https://hg.mozilla.org/integration/autoland/rev/604b9a007fe5
Part 1.1: Compensate for changes to how IPC headers are generated in the last rebase. r=mjf
https://hg.mozilla.org/integration/autoland/rev/5dc76e863a02
Part 2: Fix include-what-you-use bugs triggered by unified compilation. r=kip
https://hg.mozilla.org/integration/autoland/rev/0b85b1a7c1ce
Part 3: Get --disable-webrtc builds working. r=mjf
https://hg.mozilla.org/integration/autoland/rev/761fca0514fb
Part 4: Better logging for candidate gathering (was necessary to figure out parts of bug 1513059). r=mjf
https://hg.mozilla.org/integration/autoland/rev/d44f15fd4529
Part 5: Update IPC serialize/deserialize code for RTP stream stats to match what is in the dictionaries. r=ng
https://hg.mozilla.org/integration/autoland/rev/94b62c6f22e2
Part 6: Disable SetProxyServer for the IPC implementation until bug 1521113 is fixed or worked around. r=mjf
https://hg.mozilla.org/integration/autoland/rev/54ac1b47b736
Part 7: Create new CI jobs for media mochitests with socket process enabled. r=ahal
https://hg.mozilla.org/integration/autoland/rev/baac167868b3
Part 8: Don't run triggered check logic on obsolete streams. r=mjf

Comment 31

[Cristian Brindusan [:cbrindusan]]

Backed out 9 changesets (Bug 1521879) for flake failures at /transforms/tests.py.

Backout: https://hg.mozilla.org/integration/autoland/rev/a20e8e9240463013f54183b6b5e890d4094ffae0

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=baac167868b3bc5f2136a3889a3a154b4360c30a&selectedJob=229684969

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=229684969&repo=autoland&lineNumber=65

Comment 32

[Byron Campen [:bwc]]

Looks like there was some vertical whitespace checking I tripped over, should be corrected now:

https://phabricator.services.mozilla.com/D17942?vs=65212&id=65245&whitespace=ignore-most#toc

Comment 33

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b1d0fb94f7ed0c635a6bc19331b9dc78582081f

Comment 34

[Byron Campen [:bwc]]

Attachment: Bug 1521879 - Part 9: Re-enable the prefs service on the socket process. r?erahm

Depends on D18231

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4004105a04a
Part 1: IPC-based MediaTransport implementation r=mjf
https://hg.mozilla.org/integration/autoland/rev/48c9c643e7bb
Part 1.1: Compensate for changes to how IPC headers are generated in the last rebase. r=mjf
https://hg.mozilla.org/integration/autoland/rev/a6105ccc188c
Part 2: Fix include-what-you-use bugs triggered by unified compilation. r=kip
https://hg.mozilla.org/integration/autoland/rev/07747027c59c
Part 3: Get --disable-webrtc builds working. r=mjf
https://hg.mozilla.org/integration/autoland/rev/6b709cd9a479
Part 4: Better logging for candidate gathering (was necessary to figure out parts of bug 1513059). r=mjf
https://hg.mozilla.org/integration/autoland/rev/1addf1e15b55
Part 5: Update IPC serialize/deserialize code for RTP stream stats to match what is in the dictionaries. r=ng
https://hg.mozilla.org/integration/autoland/rev/ed6c8d3bbfde
Part 6: Disable SetProxyServer for the IPC implementation until bug 1521113 is fixed or worked around. r=mjf
https://hg.mozilla.org/integration/autoland/rev/abcb8be12adf
Part 7: Create new CI jobs for media mochitests with socket process enabled. r=ahal
https://hg.mozilla.org/integration/autoland/rev/0bb76534f207
Part 8: Don't run triggered check logic on obsolete streams. r=mjf
https://hg.mozilla.org/integration/autoland/rev/f597a73a6eac
Part 9: Re-enable the prefs service on the socket process. r=erahm

Comment 36

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/d4004105a04a
https://hg.mozilla.org/mozilla-central/rev/48c9c643e7bb
https://hg.mozilla.org/mozilla-central/rev/a6105ccc188c
https://hg.mozilla.org/mozilla-central/rev/07747027c59c
https://hg.mozilla.org/mozilla-central/rev/6b709cd9a479
https://hg.mozilla.org/mozilla-central/rev/1addf1e15b55
https://hg.mozilla.org/mozilla-central/rev/ed6c8d3bbfde
https://hg.mozilla.org/mozilla-central/rev/abcb8be12adf
https://hg.mozilla.org/mozilla-central/rev/0bb76534f207
https://hg.mozilla.org/mozilla-central/rev/f597a73a6eac

Comment 37

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/d4004105a04a
https://hg.mozilla.org/mozilla-central/rev/48c9c643e7bb
https://hg.mozilla.org/mozilla-central/rev/a6105ccc188c
https://hg.mozilla.org/mozilla-central/rev/07747027c59c
https://hg.mozilla.org/mozilla-central/rev/6b709cd9a479
https://hg.mozilla.org/mozilla-central/rev/1addf1e15b55
https://hg.mozilla.org/mozilla-central/rev/ed6c8d3bbfde
https://hg.mozilla.org/mozilla-central/rev/abcb8be12adf
https://hg.mozilla.org/mozilla-central/rev/0bb76534f207
https://hg.mozilla.org/mozilla-central/rev/f597a73a6eac

Comment 38

[Raul Gurzau (:RaulG)]

Backed out 10 changesets (bug 1521879) for causing bug 1530107. a=backout

Backout link: https://hg.mozilla.org/mozilla-central/rev/445315bbfbf9b6ba6f5ea35443881bef19ecb6a8

Comment 39

[Byron Campen [:bwc]]

Wow, we don't have a single webrtc test for private browsing. That needs to be fixed.

Comment 40

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=90a4a7b86b5791b827f6ffe30f5c0e863d5e39eb

Comment 41

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca3106034843eecea8968e96d88d05bcb309cce7

Comment 42

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f18e61be455d
Part 1: IPC-based MediaTransport implementation r=mjf
https://hg.mozilla.org/integration/autoland/rev/fd4330c37f1f
Part 1.1: Compensate for changes to how IPC headers are generated in the last rebase. r=mjf
https://hg.mozilla.org/integration/autoland/rev/92aca26a3204
Part 2: Fix include-what-you-use bugs triggered by unified compilation. r=kip
https://hg.mozilla.org/integration/autoland/rev/1f06f1722fb4
Part 3: Get --disable-webrtc builds working. r=mjf
https://hg.mozilla.org/integration/autoland/rev/9ab737c1a29a
Part 4: Better logging for candidate gathering (was necessary to figure out parts of bug 1513059). r=mjf
https://hg.mozilla.org/integration/autoland/rev/5c091f2ad086
Part 5: Update IPC serialize/deserialize code for RTP stream stats to match what is in the dictionaries. r=ng
https://hg.mozilla.org/integration/autoland/rev/259d00c5c42b
Part 6: Disable SetProxyServer for the IPC implementation until bug 1521113 is fixed or worked around. r=mjf
https://hg.mozilla.org/integration/autoland/rev/634949dfc792
Part 7: Create new CI jobs for media mochitests with socket process enabled. r=ahal
https://hg.mozilla.org/integration/autoland/rev/083dee3d2169
Part 8: Don't run triggered check logic on obsolete streams. r=mjf
https://hg.mozilla.org/integration/autoland/rev/5aa193f471ea
Part 9: Re-enable the prefs service on the socket process. r=erahm

Comment 43

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f18e61be455d
https://hg.mozilla.org/mozilla-central/rev/fd4330c37f1f
https://hg.mozilla.org/mozilla-central/rev/92aca26a3204
https://hg.mozilla.org/mozilla-central/rev/1f06f1722fb4
https://hg.mozilla.org/mozilla-central/rev/9ab737c1a29a
https://hg.mozilla.org/mozilla-central/rev/5c091f2ad086
https://hg.mozilla.org/mozilla-central/rev/259d00c5c42b
https://hg.mozilla.org/mozilla-central/rev/634949dfc792
https://hg.mozilla.org/mozilla-central/rev/083dee3d2169
https://hg.mozilla.org/mozilla-central/rev/5aa193f471ea