1530276 - Replace promiseWaitForEvent in browser_bug477014.js with BrowserTestUtils.waitForEvent

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

This is a good first bug for newcomers to Firefox development.

promiseWaitForEvent in the browser_bug477014.js test file can be replaced by the BrowserTestUtils.waitForEvent utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/browser/base/content/test/general/browser_bug477014.js#19

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/base/content/test/general/browser_bug477014.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Comment 1

[Carolina Jimenez Gomez]

Hello, can I work on it?

Comment 2

[Johann Hofmann [:johannh]]

Hi Carolina, it's awesome that you're picking things up so quickly. Since you've already solved a bug of this category, may I suggest bug 1442179 instead? It's certainly a bit more difficult and should prove a better challenge for you.

Thanks!

Comment 3

[Carolina Jimenez Gomez]

sure, can you assign it to me please?

Comment 4

[Shivam Singhal [ :championshuttler ]]

Hi Johann, can I take this up? I have a local build on my laptop as well.

Thanks

Comment 5

[Johann Hofmann [:johannh]]

Sure!

Comment 6

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1530276 - Replace promiseWaitForEvent in browser_bug477014.js with BrowserTestUtils.waitForEvent. r=johannh

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37c04ba80d68
Replace promiseWaitForEvent in browser_bug477014.js with BrowserTestUtils.waitForEvent. r=johannh

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/37c04ba80d68