1530285 - Remove waitForNewTabEvent from browser/base/content/test/siteIdentity/head.js

Status: RESOLVED FIXED

(Firefox :: Site Identity, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

This is a good first bug for newcomers to Firefox development.

The waitForNewTabEvent in browser/base/content/test/siteIdentity/head.js does not seem to be used anymore.

We can safely remove it, I think.

The code to remove is here: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/browser/base/content/test/siteIdentity/head.js#14

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Comment 1

[mariahajmal]

Hi, I would like to contribute on this. Can you please assign it to me?

Comment 2

[Johann Hofmann [:johannh]]

Of course, let me know if you need any help!

Comment 3

[mariahajmal]

Hi @johann

I am getting an error ERROR: Cannot find the target C compiler while running ./mach build command. Pls help

Actual results:

$ ./mach build
0:04.13 Clobber not needed.
0:04.16 Adding make options from None
MOZ_OBJDIR=c:/mozilla-source/mozilla-central/obj-i686-pc-mi
OBJDIR=c:/mozilla-source/mozilla-central/obj-i686-pc-mingw3
0:04.39 c:\mozilla-build\mozmake\mozmake.EXE -f client.mk -s c
0:05.19 cd c:/mozilla-source/mozilla-central/obj-i686-pc-mingw
0:05.31 c:/mozilla-source/mozilla-central/configure
0:06.88 Reexecuting in the virtualenv
0:07.51 checking for vcs source checkout... hg
0:08.13 checking for a shell... C:/mozilla-build/msys/bin/sh.e
0:10.65 checking for host system type... i686-pc-mingw32
0:10.65 checking for target system type... i686-pc-mingw32
0:10.78 checking for a shell... C:/mozilla-build/msys/bin/sh.e
0:12.81 checking for host system type... i686-pc-mingw32
0:12.81 checking for target system type... i686-pc-mingw32
0:13.09 checking for vcs source checkout... hg
0:13.09 checking whether cross compiling... no
0:13.35 checking for the target C compiler... not found
0:13.38 DEBUG: _cc: Trying cl
0:13.38 DEBUG: _cc: Trying clang-cl
0:13.38 DEBUG: _cc: Trying gcc
0:13.38 DEBUG: _cc: Trying clang
0:13.38 ERROR: Cannot find the target C compiler
0:14.30 *** Fix above errors and then restart with
0:14.30 "c:/mozilla-build/mozmake/mozmake.EXE -
"
0:14.33 mozmake.EXE: *** [client.mk:149: configure] Error 1

Comment 4

[mariahajmal]

@j(In reply to Johann Hofmann [:johannh] from comment #2)

Of course, let me know if you need any help! I am unable to resolve above mentioned issue. Can you pls help

Comment 5

[Johann Hofmann [:johannh]]

Hey, hmm, that could have several reasons, I guess. Are you following https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites?

Most importantly, have you downloaded Visual Studio and MozillaBuild and are you running this from the MozillaBuild shell?

Comment 6

[mariahajmal]

(In reply to Johann Hofmann [:johannh] from comment #5)
Thanks so much for detailed comments. I just followed the instructions again and I came to know that I installed artifact build previously. Issues have been resolved after installing 'Firefox for desktop'. Thanks again

Hey, hmm, that could have several reasons, I guess. Are you following https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites?

Most importantly, have you downloaded Visual Studio and MozillaBuild and are you running this from the MozillaBuild shell?

Comment 7

[mariahajmal]

I have removed the code but I am not sure what to do next. Are we using Phabricator for code review? And what are the steps to commit the changes. Is there any document? If yes, can you pls share the link.

Thanks

Comment 8

[Johann Hofmann [:johannh]]

(In reply to mariahajmal from comment #7)

I have removed the code but I am not sure what to do next. Are we using Phabricator for code review? And what are the steps to commit the changes. Is there any document? If yes, can you pls share the link.

Thanks

Awesome! Yes, we are using Phabricator for review, you can find instructions on how to set up Phabricator here: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

If you're not sure how to get started with mercurial (hg) to commit your changes there's a great guide by our former Outreachy intern Prathiksha here: https://medium.com/@prathikshagprasad/a-beginners-guide-to-mercurial-for-firefox-development-c17094c72c16

Comment 9

[Rizwan Syed]

Hi Mariahajmal et all, I am an Outreachy applicant. Is this bug still being worked on? If not, May I please be assigned it? Thanks :) Riz

Comment 10

[mariahajmal]

(In reply to Rizwan Syed from comment #9)
Hi, Yes I have worked on it, I just have to commit my changes.

Hi Mariahajmal et all, I am an Outreachy applicant. Is this bug still being worked on? If not, May I please be assigned it? Thanks :) Riz

Comment 11

[Rizwan Syed]

(In reply to mariahajmal from comment #10)

(In reply to Rizwan Syed from comment #9)
Hi, Yes I have worked on it, I just have to commit my changes.

Hi Mariahajmal et all, I am an Outreachy applicant. Is this bug still being worked on? If not, May I please be assigned it? Thanks :) Riz

I understand - good luck!

Comment 12

[mariahajmal]

(In reply to Johann Hofmann [:johannh] from comment #8)

I have setup phabricator and arcanist but I still confused. Should I use start-shell of mozilla-build to commit my changes?
http://prntscr.com/ms8jcr

I have setup phabricator

(In reply to mariahajmal from comment #7)

I have removed the code but I am not sure what to do next. Are we using Phabricator for code review? And what are the steps to commit the changes. Is there any document? If yes, can you pls share the link.

Thanks

Awesome! Yes, we are using Phabricator for review, you can find instructions on how to set up Phabricator here: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

If you're not sure how to get started with mercurial (hg) to commit your changes there's a great guide by our former Outreachy intern Prathiksha here: https://medium.com/@prathikshagprasad/a-beginners-guide-to-mercurial-for-firefox-development-c17094c72c16

Comment 13

[Rizwan Syed]

Her Mariahajmal,

Once you'v edited the code in your local repository, if you open your command line terminal and type 'hg commit -m' [commit message ]', (within your commit message, make sure you type the bug number)

then, type 'arc diff'

This should open up either your code editor, or the revision document in your command line terminal. Within this document, type the tests you ran, and the bug number etc.. (check out this doc for more info on how the revision document should look, as well as guidance on the commands I just typed above https://moz-conduit.readthedocs.io/en/latest/arcanist-user.html)

Once your revision document has been filled out, either close your code editor or, if you filled it out within the terminal, type CTRL+O to save the revision document, followed by CTRL+X to exit the revision document and return to the command line again.

After this is all done, you patch should be pushed to johannh to review.

Hope this helps.. Riz

(In reply to mariahajmal from comment #12)

(In reply to Johann Hofmann [:johannh] from comment #8)

I have setup phabricator and arcanist but I still confused. Should I use start-shell of mozilla-build to commit my changes?
http://prntscr.com/ms8jcr

I have setup phabricator

(In reply to mariahajmal from comment #7)

I have removed the code but I am not sure what to do next. Are we using Phabricator for code review? And what are the steps to commit the changes. Is there any document? If yes, can you pls share the link.

Thanks

Awesome! Yes, we are using Phabricator for review, you can find instructions on how to set up Phabricator here: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

If you're not sure how to get started with mercurial (hg) to commit your changes there's a great guide by our former Outreachy intern Prathiksha here: https://medium.com/@prathikshagprasad/a-beginners-guide-to-mercurial-for-firefox-development-c17094c72c16

Comment 14

[Rizwan Syed]

*Hey

** You've

Please excuse the typos

(In reply to Rizwan Syed from comment #13)

Her Mariahajmal,

Once you'v edited the code in your local repository, if you open your command line terminal and type 'hg commit -m' [commit message ]', (within your commit message, make sure you type the bug number)

then, type 'arc diff'

This should open up either your code editor, or the revision document in your command line terminal. Within this document, type the tests you ran, and the bug number etc.. (check out this doc for more info on how the revision document should look, as well as guidance on the commands I just typed above https://moz-conduit.readthedocs.io/en/latest/arcanist-user.html)

Once your revision document has been filled out, either close your code editor or, if you filled it out within the terminal, type CTRL+O to save the revision document, followed by CTRL+X to exit the revision document and return to the command line again.

After this is all done, you patch should be pushed to johannh to review.

Hope this helps.. Riz

(In reply to mariahajmal from comment #12)

(In reply to Johann Hofmann [:johannh] from comment #8)

I have setup phabricator and arcanist but I still confused. Should I use start-shell of mozilla-build to commit my changes?
http://prntscr.com/ms8jcr

I have setup phabricator

(In reply to mariahajmal from comment #7)

I have removed the code but I am not sure what to do next. Are we using Phabricator for code review? And what are the steps to commit the changes. Is there any document? If yes, can you pls share the link.

Thanks

Awesome! Yes, we are using Phabricator for review, you can find instructions on how to set up Phabricator here: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

If you're not sure how to get started with mercurial (hg) to commit your changes there's a great guide by our former Outreachy intern Prathiksha here: https://medium.com/@prathikshagprasad/a-beginners-guide-to-mercurial-for-firefox-development-c17094c72c16

Comment 15

[mariahajmal]

Attachment: Bug 1530285 - Remove waitForNewTabEvent from browser/base/content/test/siteIdentity/head.js

Removed waitForNewTabEvent from browser/base/content/test/siteIdentity/head.js as it doesn't seem to be used anymore.

Comment 16

[mariahajmal]

(In reply to Rizwan Syed from comment #13)
Thanks for your help. I wasn't able to use arc from mozilla-build start shell but its now working after modifying start up settings.

Her Mariahajmal,

Once you'v edited the code in your local repository, if you open your command line terminal and type 'hg commit -m' [commit message ]', (within your commit message, make sure you type the bug number)

then, type 'arc diff'

This should open up either your code editor, or the revision document in your command line terminal. Within this document, type the tests you ran, and the bug number etc.. (check out this doc for more info on how the revision document should look, as well as guidance on the commands I just typed above https://moz-conduit.readthedocs.io/en/latest/arcanist-user.html)

Once your revision document has been filled out, either close your code editor or, if you filled it out within the terminal, type CTRL+O to save the revision document, followed by CTRL+X to exit the revision document and return to the command line again.

After this is all done, you patch should be pushed to johannh to review.

Hope this helps.. Riz

(In reply to mariahajmal from comment #12)

(In reply to Johann Hofmann [:johannh] from comment #8)

I have setup phabricator and arcanist but I still confused. Should I use start-shell of mozilla-build to commit my changes?
http://prntscr.com/ms8jcr

I have setup phabricator

(In reply to mariahajmal from comment #7)

I have removed the code but I am not sure what to do next. Are we using Phabricator for code review? And what are the steps to commit the changes. Is there any document? If yes, can you pls share the link.

Thanks

Awesome! Yes, we are using Phabricator for review, you can find instructions on how to set up Phabricator here: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

If you're not sure how to get started with mercurial (hg) to commit your changes there's a great guide by our former Outreachy intern Prathiksha here: https://medium.com/@prathikshagprasad/a-beginners-guide-to-mercurial-for-firefox-development-c17094c72c16

Comment 17

[mariahajmal]

Attachment: Bug 1530285 - Remove waitForNewTabEvent from browser/base/content/test/siteIdentity/head.js. r=johannh

Removed waitForNewTabEvent from browser/base/content/test/siteIdentity/head.js as it doesn't seem to be used anymore.

Comment 18

[Johann Hofmann [:johannh]]

Hey mariahajmal, are you still working on this bug? :)

Comment 19

[mariahajmal]

Please review the updated patch. Thanks

(In reply to Johann Hofmann [:johannh] from comment #18)

Hey mariahajmal, are you still working on this bug? :)

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cbf736c77c2
Remove waitForNewTabEvent from browser/base/content/test/siteIdentity/head.js r=johannh

Comment 21

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7cbf736c77c2