1530341 - Export Changes - add Copy All Changes button

Status: RESOLVED FIXED

(DevTools :: Inspector: Changes, enhancement)

Description

[Razvan Caliman [:rcaliman]]

Provide a UI control to copy all CSS changes form all sources (stylesheets, element styles) to the clipboard.
The clipboard content format is as described in Bug 1524548.

Changes are grouped by source. Each group is prefaced by a code comment listing the style source path (for linked stylesheets) or type (for inline styleshets and element styles)

Example clipboard output for a removed font-size declaration from a linked stylesheet and an added font-size declaration to an element style:

/* style.css | https://example.com/style.css */

body {
  /* font-size: 1rem; */
}

/* Element | https://example.com */

body {
  font-size: 33px;
}

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1530341 - (Part 1) Remove Copy Changes and Copy All Changes context menu options. r=gl

Remove the Copy All and Copy All Changes context menu options form the Changes panel context menu.
As per decided by PM & UX, they will be replaced with a single Copy All Changes button in the toolbar (part 2 of this series).

Comment 2

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1530341 - (Part 2) Add Copy All Changes button to Changes panel. r=gl

Depends on D20808

Adds a Copy All Changes button to the toolbar of the Changes panel.
When pressed, this builds a stylesheet out of the changes for all sources tracked (stylesheets, element styles, etc)
The output format is the same as the now defunct Bug 1524548 with the added code comment as separator between the sources.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c74db63f9aa
(Part 1) Remove Copy Changes and Copy All Changes context menu options. r=gl
https://hg.mozilla.org/integration/autoland/rev/8a760030e793
(Part 2) Add Copy All Changes button to Changes panel. r=gl

Comment 4

[Arthur Iakab [arthur_iakab]]

These revisions were backed out because they were causing bckout conflict when backing out 96e76fdfd8b2 Bug 1529606

Backed out 3 changesets (bug 1530341, bug 1529606) for causing devtools failures on browser_parsable_css.js CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/4613c00d3163dac8523877feeed7a661efd9510b

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=230367398&revision=8a760030e793ae022a93bfc1b62e29686f7df5f6

:rcaliman can you please take a look? Alsso please see https://bugzilla.mozilla.org/show_bug.cgi?id=1529606

Comment 5

[Razvan Caliman [:rcaliman]]

Removed unused CSS custom properties which tripped a pedantic test and pushed again.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d744e4b84443
(Part 1) Remove Copy Changes and Copy All Changes context menu options. r=gl
https://hg.mozilla.org/integration/autoland/rev/ea28e78057d5
(Part 2) Add Copy All Changes button to Changes panel. r=gl

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d744e4b84443
https://hg.mozilla.org/mozilla-central/rev/ea28e78057d5