Closed
Bug 1530406
Opened 7 years ago
Closed 7 years ago
Make HashableValue comparison of BigInts infallible
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: terpri, Assigned: terpri)
References
Details
Attachments
(1 external file)
HashableValue::operator== currently uses SameValue to compare BigInt values that are not identical but may be mathematically equal. BigInt::equal should be used instead, since unlike SameValue it is infallible and doesn't require access to a JSContext.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → robin
Blocks: js-bigint-ship
|
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d209ceb7588c
Make HashableValue comparison of BigInts infallible r=wingo,jwalden
Keywords: checkin-needed
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
|
||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/projects/oak/rev/d209ceb7588c9060ac427ffc76abacce9cdffb02
Bug 1530406 - Make HashableValue comparison of BigInts infallible r=wingo,jwalden
You need to log in
before you can comment on or make changes to this bug.
Description
•