QuantumBar should notify WebExtension's WebNavigation of transition data

RESOLVED FIXED in Firefox 68

Status

enhancement
P2
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Blocks 4 bugs)

unspecified
mozilla68
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox68 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

Assignee

Description

4 months ago

For the existing address bar, WebNavigation.jsm listens to autocomplete-did-enter-text to get details about transition types for tabs/history.

https://searchfox.org/mozilla-central/rev/b10ae6b7a50d176a813900cbe9dc18c85acd604b/toolkit/modules/addons/WebNavigation.jsm#132-205

We need to port the code to work with QuantumBar - and ensure we get browser/components/extensions/test/browser/browser_ext_webNavigation_urlbar_transitions.js passing.

Assignee

Updated

4 months ago
Assignee

Comment 2

4 months ago

The WIP patch is just to port the test to UrlbarTestUtils and hopefully it should run. I'm not sure if it'll need more work once the main patch is fixed.

I'm not planning on working on this in the short term.

(In reply to Mark Banner (:standard8) from comment #2)

The WIP patch is just to port the test to UrlbarTestUtils and hopefully it should run. I'm not sure if it'll need more work once the main patch is fixed.

I'm not planning on working on this in the short term.

Given this, would it be OK to P5 this to get it off our triage? I don't want to close it prematurely, but I also don't want to track it if it's going to be addressed by something else.

Flags: needinfo?(standard8)
Assignee

Comment 4

4 months ago

From a QuantumBar point of view this is probably a P2. I suspect one of us will be fixing it fairly soon as we're getting to the end of QuantumBar issues.

Flags: needinfo?(standard8)
Assignee

Comment 5

4 months ago

Having said that, I'm now in a position that I'm going to work on it.

Assignee: nobody → standard8
Priority: -- → P2
Attachment #9046700 - Attachment description: Bug 1530675 - WIP Port browser_ext_webNavigation_urlbar_transitions.js to QuantumBar → Bug 1530675 - Enable WebNavigation transistion notifications for WebExtensions with QuantumBar. r?mak!,r?aswan!
Attachment #9046700 - Attachment description: Bug 1530675 - Enable WebNavigation transistion notifications for WebExtensions with QuantumBar. r?mak!,r?aswan! → Bug 1530675 - Enable WebNavigation transistion notifications for WebExtensions with QuantumBar. r?mak!,rpl!

Comment 6

3 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8aef30b8a2be
Enable WebNavigation transistion notifications for WebExtensions with QuantumBar. r=mak,rpl

Comment 7

3 months ago
bugherder
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Comment 8

3 months ago

Can you please provide some STR for this issue so we can check it manually? If no manual testing is needed please mark it as "qe-verify- "

Flags: needinfo?(standard8)
Assignee

Comment 9

3 months ago

This has good test coverage that's working both pre and post QuantumBar, so I don't think we need additional testing here.

Flags: needinfo?(standard8) → qe-verify-
You need to log in before you can comment on or make changes to this bug.