Closed Bug 1530765 Opened 9 months ago Closed 9 months ago

Replace waitForEvent in browser_pageinfo_firstPartyIsolation.js with BrowserTestUtils.waitForEvent

Categories

(Firefox :: Page Info Window, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: johannh, Assigned: jawad, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file, 2 obsolete files)

This is a good first bug for newcomers to Firefox development.

waitForEvent in the browser_pageinfo_firstPartyIsolation.js test file can be replaced by the BrowserTestUtils.waitForEvent utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/b10ae6b7a50d176a813900cbe9dc18c85acd604b/browser/base/content/test/pageinfo/browser_pageinfo_firstPartyIsolation.js#3,35,37,84

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest base/content/test/pageinfo/browser_pageinfo_firstPartyIsolation.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Hi, I am willing to work on this bug, please assign it to me.

Sure, thank you!

Assignee: nobody → ijawadak
Status: NEW → ASSIGNED
Comment on attachment 9046902 [details] [diff] [review]
waitForEvent in the browser_pageinfo_firstPartyIsolation.js replaced by the BrowserTestUtils.waitForEvent utility function

Review of attachment 9046902 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry if my description was unclear, the idea is to stop using the `waitForEvent` function and utilizing `BrowserTestUtils.waitForEvent` instead, so you can just remove the function definition entirely :)

Also note that you will have to start using Phabricator soon, since we will be shutting down code review via Bugzilla, I think about tomorrow.

Thanks!
Attachment #9046902 - Flags: review?(jhofmann) → review-

Hi, sorry for my misunderstanding, thank you for your helpful reply.

Attachment #9046902 - Attachment is obsolete: true
Attachment #9047025 - Flags: review?(jhofmann)
Comment on attachment 9047025 [details] [diff] [review]
waitForEvent in the browser_pageinfo_firstPartyIsolation.js replaced by the BrowserTestUtils.waitForEvent utility function

Review of attachment 9047025 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks!
Attachment #9047025 - Flags: review?(jhofmann) → review+

Oh, one thing, please format your commit message like this:

Bug 1530765 - Replace waitForEvent in the browser_pageinfo_firstPartyIsolation.js by the BrowserTestUtils.waitForEvent utility function. r=johannh

and upload the patch again. Then we can get it landed :)

Formatted commit message.

Attachment #9047025 - Attachment is obsolete: true
Attachment #9047060 - Flags: review?(jhofmann)
Comment on attachment 9047060 [details] [diff] [review]
waitForEvent in the browser_pageinfo_firstPartyIsolation.js by the BrowserTestUtils.waitForEvent utility function

Review of attachment 9047060 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #9047060 - Flags: review?(jhofmann) → review+

Let's get this landed!

Keywords: checkin-needed

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e743e4fa9a4d
Replace waitForEvent in the browser_pageinfo_firstPartyIsolation.js by the BrowserTestUtils.waitForEvent utility function. r=johannh CLOSED TREE

Keywords: checkin-needed

(In reply to Johann Hofmann [:johannh] from comment #10)

Let's get this landed!

Thank you :)

Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.