1530774 - Remove support for main thread blending of animated image frames

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, enhancement, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

We've shipped with image.animated.generate-full-frames turned on in bug 1508393 since 65. There has not been any serious issues reported, so let's start ripping out the old FrameAnimator blending code for 68.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1530774 - Part 1. Remove support in FrameAnimator for blending partial/paletted frames.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1530774 - Part 2. Remove support for paletted surface pipes.

Depends on D23714

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1530774 - Part 3. Remove decoder support for producing paletted frames.

Depends on D23715

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

FrameAnimator/AnimationState needs further restructuring. I haven't gotten around to it yet. In an ideal world AnimationSurfaceProvider will be what keeps track of the animation state, and RasterImage just tells it to advance. That will save memory for non-animated images in addition to no longer need to sync the frame indices between FrameAnimator and AnimationSurfaceProvider.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3315d784208
Part 1. Remove support in FrameAnimator for blending partial/paletted frames. r=tnikkel
https://hg.mozilla.org/integration/mozilla-inbound/rev/6dd55ee89611
Part 2. Remove support for paletted surface pipes. r=tnikkel
https://hg.mozilla.org/integration/mozilla-inbound/rev/52390d9090fb
Part 3. Remove decoder support for producing paletted frames. r=tnikkel

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/e3315d784208
https://hg.mozilla.org/mozilla-central/rev/6dd55ee89611
https://hg.mozilla.org/mozilla-central/rev/52390d9090fb