1530781 - Replace waitForCondition in browser_901207_searchbar_in_panel.js withTestUtils.waitForCondition

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, task, P5)

Description

[Johann Hofmann [:johannh]]

This is a good first bug for newcomers to Firefox development.

waitForCondition usage in the browser_901207_searchbar_in_panel.js test file can be replaced by the TestUtils.waitForCondition utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/browser/components/customizableui/test/browser_901207_searchbar_in_panel.js#11,61,72,84

There are multiple occurrences that need to be replaced.

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/components/customizableui/test/browser_901207_searchbar_in_panel.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Comment 1

[patienceankundat]

I would like to be assigned this bug

Comment 2

[Johann Hofmann [:johannh]]

Absolutely, thanks!

Comment 3

[patienceankundat]

Attachment: replaced waitForCondition() with TestUtils.waitForCondition()

Comment 4

[Johann Hofmann [:johannh]]

(In reply to patienceankundat from comment #3)

Created attachment 9047275 [details]
replaced waitForCondition() with TestUtils.waitForCondition()

Hi patienceankundat, you upload the updated file, but unfortunately we can't accept patches that way. Please upload a patch using Phabricator. There's a guide on how to get started with Phabricator here: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

If you don't know how to make patches with hg, there's a great intro to the most common commands here: https://medium.com/@prathikshagprasad/a-beginners-guide-to-mercurial-for-firefox-development-c17094c72c16

Thanks!

Comment 5

[patienceankundat]

I see. I knew there was something missing. Thank you for references. Let me check them out and do the right procedure.

Comment 6

[albert.xie]

Hi all, I understand this ticket has already been assigned, please let me know if there is anything I can do if this is not resolved in the near future.

Comment 7

[Johann Hofmann [:johannh]]

Hey Patience, are you still working on this bug? :)

Comment 8

[patienceankundat]

Hey, unfortunately, I am unable to work on this bug. It can be assigned to another person. Thank you

Comment 9

[Johann Hofmann [:johannh]]

Ok, thank you for the update!

Comment 10

[Asra Q [:aqadri]]

Hi Johann, Can I please take this?

Comment 11

[Johann Hofmann [:johannh]]

Hey, I would prefer to leave this bug to someone who's completely new to Firefox development. I'll message you to find a good next bug to work.

Comment 12

[Asra Q [:aqadri]]

(In reply to Johann Hofmann [:johannh] from comment #11)

Hey, I would prefer to leave this bug to someone who's completely new to Firefox development. I'll message you to find a good next bug to work.

Okay, thanks!

Comment 13

[trushita]

Hi Johann, I am an outreachy applicant. can i take this up if nobody is working on it?

Comment 14

[nikhilrastogi1996]

Hi Johann, I'm completely new to Firefox development. Can I take this bug?

Comment 15

[Johann Hofmann [:johannh]]

Hey, sorry for the delay. Trushita, if you get in touch I'm happy to help you find another bug to work on, I would like to reserve this bug for completely new folks.

nikhilrastogi1996, I assigned you to the bug. Let me know if you need any help.

Thanks!

Comment 16

[trushita]

No problem Johann. I would be interested in working on another bug. Where can I get in touch? Thanks for the help.

Comment 17

[Johann Hofmann [:johannh]]

Needinfo'd you on another bug :)

Comment 18

[Johann Hofmann [:johannh]]

Unassigning due to inactivity, let me know if you want to take this up again.

Comment 19

[Megha [ :meghaaa ]]

I would like to work on it, can I take this up?

Comment 20

[Johann Hofmann [:johannh]]

Absolutely, let me know if you need any help!

Comment 21

[Megha [ :meghaaa ]]

Attachment: Bug 1530781 - Replaced waitForCondition in browser_901207_searchbar_in_panel.js with TestUtils.waitForCondition. r=johannh

Depends on D41948

Comment 22

[Johann Hofmann [:johannh]]

Setting checkin-needed to get this landed.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b260fa5b5fb2
Replaced waitForCondition in browser_901207_searchbar_in_panel.js with TestUtils.waitForCondition. r=johannh

Comment 24

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b260fa5b5fb2