Closed Bug 1530781 Opened 11 months ago Closed 5 months ago

Replace waitForCondition in browser_901207_searchbar_in_panel.js withTestUtils.waitForCondition

Categories

(Firefox :: Toolbars and Customization, task, P5)

task

Tracking

()

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: johannh, Assigned: meghaaa, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(2 files)

This is a good first bug for newcomers to Firefox development.

waitForCondition usage in the browser_901207_searchbar_in_panel.js test file can be replaced by the TestUtils.waitForCondition utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/browser/components/customizableui/test/browser_901207_searchbar_in_panel.js#11,61,72,84

There are multiple occurrences that need to be replaced.

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/components/customizableui/test/browser_901207_searchbar_in_panel.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

I would like to be assigned this bug

Absolutely, thanks!

Assignee: nobody → patienceankundat
Status: NEW → ASSIGNED

(In reply to patienceankundat from comment #3)

Created attachment 9047275 [details]
replaced waitForCondition() with TestUtils.waitForCondition()

Hi patienceankundat, you upload the updated file, but unfortunately we can't accept patches that way. Please upload a patch using Phabricator. There's a guide on how to get started with Phabricator here: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

If you don't know how to make patches with hg, there's a great intro to the most common commands here: https://medium.com/@prathikshagprasad/a-beginners-guide-to-mercurial-for-firefox-development-c17094c72c16

Thanks!

I see. I knew there was something missing. Thank you for references. Let me check them out and do the right procedure.

Hi all, I understand this ticket has already been assigned, please let me know if there is anything I can do if this is not resolved in the near future.

Hey Patience, are you still working on this bug? :)

Flags: needinfo?(patienceankundat)

Hey, unfortunately, I am unable to work on this bug. It can be assigned to another person. Thank you

Flags: needinfo?(patienceankundat)

Ok, thank you for the update!

Assignee: patienceankundat → nobody
Status: ASSIGNED → NEW

Hi Johann, Can I please take this?

Hey, I would prefer to leave this bug to someone who's completely new to Firefox development. I'll message you to find a good next bug to work.

(In reply to Johann Hofmann [:johannh] from comment #11)

Hey, I would prefer to leave this bug to someone who's completely new to Firefox development. I'll message you to find a good next bug to work.

Okay, thanks!

Hi Johann, I am an outreachy applicant. can i take this up if nobody is working on it?

Flags: needinfo?(jhofmann)

Hi Johann, I'm completely new to Firefox development. Can I take this bug?

Hey, sorry for the delay. Trushita, if you get in touch I'm happy to help you find another bug to work on, I would like to reserve this bug for completely new folks.

nikhilrastogi1996, I assigned you to the bug. Let me know if you need any help.

Thanks!

Assignee: nobody → nikhilrastogi1996
Status: NEW → ASSIGNED
Flags: needinfo?(jhofmann)

No problem Johann. I would be interested in working on another bug. Where can I get in touch? Thanks for the help.

Needinfo'd you on another bug :)

Unassigning due to inactivity, let me know if you want to take this up again.

Assignee: nikhilrastogi1996 → nobody
Status: ASSIGNED → NEW
Type: enhancement → task

I would like to work on it, can I take this up?

Flags: needinfo?(jhofmann)

Absolutely, let me know if you need any help!

Assignee: nobody → meghajais.mj
Status: NEW → ASSIGNED
Flags: needinfo?(jhofmann)

Setting checkin-needed to get this landed.

Keywords: checkin-needed

Pushed by malexandru@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b260fa5b5fb2
Replaced waitForCondition in browser_901207_searchbar_in_panel.js with TestUtils.waitForCondition. r=johannh

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Attachment #9085693 - Attachment is obsolete: true
Attachment #9085693 - Attachment is obsolete: false
You need to log in before you can comment on or make changes to this bug.