1530787 - Replace waitForCondition in browser_914138_widget_API_overflowable_toolbar.js withTestUtils.waitForCondition

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

This is a good first bug for newcomers to Firefox development.

waitForCondition usage in the browser_914138_widget_API_overflowable_toolbar.js test file can be replaced by the TestUtils.waitForCondition utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/browser/components/customizableui/test/browser_914138_widget_API_overflowable_toolbar.js#27,44,69,81,98

There are multiple occurrences that need to be replaced.

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/components/customizableui/test/browser_914138_widget_API_overflowable_toolbar.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Comment 1

[Josef Citrine (:jcit)]

Hi, I'd like to be assigned this as my first bug

Comment 2

[Josef Citrine (:jcit)]

Attachment: Bug 1530787 - Replace waitForConditon in browser_914138 with TestUtils.waitForCondition

Comment 3

[Johann Hofmann [:johannh]]

Great, thanks!

Comment 4

[Johann Hofmann [:johannh]]

Setting checkin-needed to get this checked in by someone...

Comment 5

[Oana Pop-Rus]

Unable to land through Lando: it says revision blocked.

Can you take a look at this?

Comment 6

[Josef Citrine (:jcit)]

Looks like I messed up while creating the diff, project wasn't assigned. I'll try to submit it again

Comment 7

[Josef Citrine (:jcit)]

Attachment: Bug 1530787 - Replace waitForConditon in browser_914138 with TestUtils.waitForCondition

Replace all calls to waitForConditon with TestUtils.waitForCondition

Comment 8

[Josef Citrine (:jcit)]

I'll need to look into this later. It looks like that didn't fix it. I'm gonna fix my dev environment and get this resubmitted. Sorry about all this, still learning how to contribute

Comment 9

[Josef Citrine (:jcit)]

Attachment: Bug 1530787 - Replace waitForConditon in browser_914138 with TestUtils.waitForCondition

Comment 10

[Josef Citrine (:jcit)]

Finally got it working. Was missing moz-phab.

Looks like it's not blocking in Lando anymore.

Comment 11

[Razvan Maries]

(In reply to Johann Hofmann [:johannh] from comment #4)

Setting checkin-needed to get this checked in by someone...

Removing the tag. Please add it only after you've granted review because it shows up in our landing filter.
Thanks!

Comment 12

[Johann Hofmann [:johannh]]

Landing it myself, sorry for the confusion :)

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c923d2b7817e
Replace waitForConditon in browser_914138 with TestUtils.waitForCondition r=johannh

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c923d2b7817e