1530815 - Crash in [@ r_assoc_fetch_bucket]

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P1)

Description

[Calixte Denizet (:calixte)]

This bug is for crash report bp-30866bb4-e544-4eb6-940a-b22070190226.

Top 10 frames of crashing thread:

0 libxul.so r_assoc_fetch_bucket media/mtransport/third_party/nrappkit/src/util/libekr/r_assoc.c:250
1 libxul.so nr_reg_fetch_node media/mtransport/third_party/nrappkit/src/util/libekr/r_assoc.c:271
2 libxul.so nr_reg_set media/mtransport/third_party/nrappkit/src/registry/registry_local.c:617
3 libxul.so nr_reg_local_set_uchar media/mtransport/third_party/nrappkit/src/registry/registry_local.c:986
4 libxul.so mozilla::NrIceCtx::InitializeGlobals media/mtransport/nricectx.cpp:454
5 libxul.so mozilla::NrIceCtx::Create media/mtransport/nricectx.cpp:286
6 libxul.so mozilla::MediaTransportHandlerSTS::CreateIceCtx media/webrtc/signaling/src/peerconnection/MediaTransportHandler.cpp:339
7 libxul.so mozilla::PeerConnectionImpl::Initialize media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:473
8 libxul.so mozilla::PeerConnectionImpl::Initialize media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:545
9 libxul.so mozilla::dom::PeerConnectionImpl_Binding::initialize dom/bindings/PeerConnectionImplBinding.cpp:97

There are 3 crashes (from 3 installations) in nightly 67 with buildid 20190226093755. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1521879.

[1] https://hg.mozilla.org/mozilla-central/rev?node=f18e61be455d

Comment 1

[Byron Campen [:bwc]]

This is extremely odd; it seems that the nr_registry stuff is failing to init for some reason, but I cannot see a reason why that might be...

Looking into it.

Comment 2

[Byron Campen [:bwc]]

Maybe we should be initting NSS before we try to init the nr_registry stuff?

Comment 3

[Byron Campen [:bwc]]

I have an idea of what might be happening. Patch coming up.

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=84416b81a54c0d03367dddaf8673190214a2b59c

Comment 5

[Byron Campen [:bwc]]

Attachment: Bug 1530815: Call RLogConnector::CreateInstance on main, not STS, because that's where we init the nr_registry stuff normally. r?mjf

Comment 6

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e2e37a89cf81334ef1d4245b8832a6afd387b93&selectedJob=230786844

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ee6e4e37189
Call RLogConnector::CreateInstance on main, not STS, because that's where we init the nr_registry stuff normally. r=mjf

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/4ee6e4e37189