Closed Bug 1530879 Opened 1 year ago Closed 1 year ago

Update our test262 import through February 6

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(20 files)

1.05 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
67.42 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
29.58 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
5.72 MB, patch
jorendorff
: review+
Details | Diff | Splinter Review
6.03 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
51.57 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
56.04 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
87.30 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
211.57 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
8.80 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
3.55 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
31.13 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
3.78 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
13.70 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
2.85 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
21.66 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
4.83 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
69.82 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
4.32 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
18.53 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review

Our test262 import hasn't been refreshed in three months, and everything is skew. :-|

Most obnoxious of all, we have a locally-landed test262 test that will get blown away by every test262 import right now. Unfortunately, updating through February 6 will not actually pick up the upstream test. But that's as far as I can go before I encounter a test that doesn't import right, for no obvious reason I can figure out. :-| So I'm going to pocket what I've done, then start doing tricky things in a separate bug.

The hashbang tests begin to be landed *immediately after* all this bug's import-work, but I have this done now, it needs to be added, might as well do it now.

(Why do the hashbang tests not import right?  My best guess is that because they necessarily require the YAML-comment *not* be at start of the file, the test parser doesn't understand that, and so the tests aren't excluded by feature-check.  Blah.)
Attachment #9046904 - Flags: review?(jorendorff)
This is just running the script, no need to skip any new/modified tests that begin to fail.
Attachment #9046905 - Flags: review?(jorendorff)
So these patches will alternate -- one that does a plain ol' update, then one that picks up revisions where we have to manually skip tests because we're not up to spec.  This is the first such rev.

I belatedly observe I should have filed a bug for this skip-list -- I do for all the following ones -- but I'm in an |hg bzexport| window now and can't easily back out.  Pretend I added a bug number here when reviewing, will do before landing.
Attachment #9046906 - Flags: review?(jorendorff)
This is just running the script, no need to skip any new/modified tests that begin to fail.

(Except that I'd have to manually undo the tojson-receiver.js change that would be made if I hadn't generated this atop a tree where such had already been removed.  Ugh**infinity.)
Attachment #9046913 - Flags: review?(jorendorff)
Upstream added these tests even tho they were wrong from the start because the JSON superset thing had already landed upstream.  Feh.  Disabled here, subsequent patch in this bug will remove this entry concurrent with removing these tests.
Attachment #9046914 - Flags: review?(jorendorff)
This is just running the script, no need to skip any new/modified tests that begin to fail.

(Except that I'd have to manually undo the tojson-receiver.js change that would be made if I hadn't generated this atop a tree where such had already been removed.  Ugh**infinity.)
Attachment #9046915 - Flags: review?(jorendorff)
There's no special test262 feature-guard for bigint typed arrays, so we gotta skip these manually for now.
Attachment #9046917 - Flags: review?(jorendorff)
This is just running the script, no need to skip any new/modified tests that begin to fail.

(Except that I'd have to manually undo the tojson-receiver.js change that would be made if I hadn't generated this atop a tree where such had already been removed.  Ugh**infinity.)
Attachment #9046918 - Flags: review?(jorendorff)
This is just running the script, no need to skip any new/modified tests that begin to fail.

(Except that I'd have to manually undo the tojson-receiver.js change that would be made if I hadn't generated this atop a tree where such had already been removed.  Ugh**infinity.)

(...oops, I neglected to collapse the last patch and this one together.  Oh well.)
Attachment #9046924 - Flags: review?(jorendorff)
And now the JSON superset-obsoleted tests go bye again.
Attachment #9046926 - Flags: review?(jorendorff)
This is just running the script, no need to skip any new/modified tests that begin to fail.

(Except that I'd have to manually undo the tojson-receiver.js change that would be made if I hadn't generated this atop a tree where such had already been removed.  Ugh**infinity.)
Attachment #9046927 - Flags: review?(jorendorff)
Not sure if bug on file for this, my head hurts and I want to get this landed and we can circle back later maybe?
Attachment #9046928 - Flags: review?(jorendorff)
This is just running the script, no need to skip any new/modified tests that begin to fail.

(Except that I'd have to manually undo the tojson-receiver.js change that would be made if I hadn't generated this atop a tree where such had already been removed.  Ugh**infinity.)
Attachment #9046929 - Flags: review?(jorendorff)
This is just running the script, no need to skip any new/modified tests that begin to fail.

(Except that I'd have to manually undo the tojson-receiver.js change that would be made if I hadn't generated this atop a tree where such had already been removed.  Ugh**infinity.)
Attachment #9046931 - Flags: review?(jorendorff)
This is just running the script, no need to skip any new/modified tests that begin to fail.

(Except that I'd have to manually undo the tojson-receiver.js change that would be made if I hadn't generated this atop a tree where such had already been removed.  Ugh**infinity.)
Attachment #9046933 - Flags: review?(jorendorff)
...and at this point we're up to nearly current times.  Remaining updates will be left to another bug.
Attachment #9046935 - Flags: review?(jorendorff)
Comment on attachment 9046904 [details] [diff] [review]
Add hashbang as an unsupported feature when importing test262 tests, in anticipation of importing tests for it prior to our implementing it

Review of attachment 9046904 [details] [diff] [review]:
-----------------------------------------------------------------

OK.
Attachment #9046904 - Flags: review?(jorendorff) → review+
Comment on attachment 9046905 [details] [diff] [review]
Update the test262 import to upstream rev dab8c8983adc37ed3da672442e0e378ff6cd2714

Review of attachment 9046905 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #9046905 - Flags: review?(jorendorff) → review+
Comment on attachment 9046906 [details] [diff] [review]
Update the test262 import to upstream rev 73705f88014183b3eab8593f91ec769d957cd200

Review of attachment 9046906 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #9046906 - Flags: review?(jorendorff) → review+
Comment on attachment 9046913 [details] [diff] [review]
Update the test262 import to upstream rev 8175f6c05eef922c062e8f5bfae0faaef9404202

Review of attachment 9046913 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #9046913 - Flags: review?(jorendorff) → review+
Attachment #9046914 - Flags: review?(jorendorff) → review+
Attachment #9046915 - Flags: review?(jorendorff) → review+
Attachment #9046917 - Flags: review?(jorendorff) → review+
Attachment #9046918 - Flags: review?(jorendorff) → review+
Attachment #9046924 - Flags: review?(jorendorff) → review+
Attachment #9046925 - Flags: review?(jorendorff) → review+
Attachment #9046926 - Flags: review?(jorendorff) → review+
Attachment #9046927 - Flags: review?(jorendorff) → review+
Comment on attachment 9046928 [details] [diff] [review]
Update the test262 import to upstream rev 116c95d97ce3982c45d955ab596c7b55efd51a8f

Review of attachment 9046928 [details] [diff] [review]:
-----------------------------------------------------------------

Please do circle back and add a bug number before landing.
Attachment #9046928 - Flags: review?(jorendorff) → review+
Attachment #9046929 - Flags: review?(jorendorff) → review+
Attachment #9046930 - Flags: review?(jorendorff) → review+
Attachment #9046931 - Flags: review?(jorendorff) → review+
Comment on attachment 9046932 [details] [diff] [review]
Update the test262 import to upstream rev 72381359409f06933889943d94d6c8f6812def94

Review of attachment 9046932 [details] [diff] [review]:
-----------------------------------------------------------------

r=me to do whatever seems to make sense here. The patch fixing this bug will probably beat you to m-c.

::: js/src/tests/jstests.list
@@ +1239,5 @@
>  skip script test262/built-ins/RegExp/prototype/ignoreCase/cross-realm.js
>  skip script test262/built-ins/RegExp/prototype/unicode/cross-realm.js
>  skip script test262/built-ins/RegExp/prototype/source/cross-realm.js
>  
> +# flat/flatMap need to be added to Array unscopables -- bug 1530865.

This is bug 1523785, which has a patch that's currently checkin-needed! So please take care landing this.
Attachment #9046932 - Flags: review?(jorendorff) → review+
Attachment #9046933 - Flags: review?(jorendorff) → review+
Comment on attachment 9046934 [details] [diff] [review]
Update the test262 import to upstream rev 9280e1f872151f68cac99bc0c674527813a91cf9

Review of attachment 9046934 [details] [diff] [review]:
-----------------------------------------------------------------

Same deal—there's already a patch, although this one's less likely to beat you to m-c. r=me however it works out.
Attachment #9046934 - Flags: review?(jorendorff) → review+
Attachment #9046935 - Flags: review?(jorendorff) → review+
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7af55c5b089d
Add hashbang as an unsupported feature when importing test262 tests, in anticipation of importing tests for it prior to our implementing it.  r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/3fa28490c946
Update the test262 import to upstream rev dab8c8983adc37ed3da672442e0e378ff6cd2714.  rs=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/467495eead9f
Update the test262 import to upstream rev 73705f88014183b3eab8593f91ec769d957cd200.  rs=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/18308efff141
Update the test262 import to upstream rev 8175f6c05eef922c062e8f5bfae0faaef9404202.  rs=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/66478b6fc575
Update the test262 import to upstream rev 3468dad291251d4759ab6270d4fb8b75befa8d93.  r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/110995301abe
Update the test262 import to upstream rev d0f57bff727cc8e06e4a7c2202edc0521a678fe9.  r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/013df3288f6e
Update the test262 import to upstream rev 08d827565b6d573973aa870ea40f3f7f6936ebfd.  r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/258f158867fc
Update the test262 import to upstream rev a338b5f744adedbe6e548ae712c44d85b05f5157.  r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/797e4b802321
Update the test262 import to upstream rev d53256c971f3b6b6d709a909446919b7bb56f3b5.  r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/56404185f101
Update the test262 import to upstream rev 4f1155c566a222238fd86f179c6635ecb4c289bb.  r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/03c7eccbb595
Update the test262 import to upstream rev d7c8a12e68af1f8713082b73ff25a945c9c597d5.  r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/d43af7026a45
Update the test262 import to upstream rev b7c9c6c78b65f63df93650c11476225f38bcd1fa.  r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/075e7b029552
Update the test262 import to upstream rev 116c95d97ce3982c45d955ab596c7b55efd51a8f.  r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/a088ba848e63
Update the test262 import to upstream rev b337eaf7c7b9bb90991132d0018fdd1d441545ae.  r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f34e2faf030
Update the test262 import to upstream rev 5eab51827b434131d71c6aa0d306284eb50f3cc9.  r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/c86ae31a2595
Update the test262 import to upstream rev afe1b5adc7d961e4daf261867ffa9fd3d22b1235.  r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/2990c1cb8548
Update the test262 import to upstream rev 72381359409f06933889943d94d6c8f6812def94.  r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f433cf2ba16
Update the test262 import to upstream rev e39604fa41b1ad0effdcf586e4d554ff2d8c3eb7.  r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/846ec57d36ae
Update the test262 import to upstream rev 9280e1f872151f68cac99bc0c674527813a91cf9.  r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/96045963f36c
Update the test262 import to upstream rev 33a306d1026b72227eb50a918db19ada16f12b3d.  r=jorendorff
You need to log in before you can comment on or make changes to this bug.