Closed Bug 1530896 Opened 1 year ago Closed 1 year ago

Adjust CSS parser to un-recognize `contain:style` for now

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

The CSSWG just discussed contain:style and resolved on the following:
* RESOLVED: remove style containment from keywords that aren't 'style'
* RESOLVED: mark 'style' at risk
* RESOLVED: Republish CR of css-contain once edits are in

https://github.com/w3c/csswg-drafts/issues/3280#issuecomment-467588765

For our initially shipping version of css containment, we're going to drop support for style from our CSS parser right now (and remove it from the content and strict keywords, per the first CSSWG resolution above).

Filing this bug on doing that.

Blocks: 1532471

We're not sure we're going to ship support for this value, and it's been marked
as 'at-risk' in the spec, so let's stop pretending we support it in the parser.

Spec issue:
https://github.com/w3c/csswg-drafts/issues/3280

Depends on: 1532835

Looks like we need some annotations and/or adjustments for the css/css-contain/parsing/contain-computed.html web platform test.

Flags: needinfo?(dholbert)

Try run with the wpt tests (for parsing contain:style [xyz]) annotated as failing:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ebe798ec1b4d219f34898cf7c41307a0c82eeb8

Once more with annotations for another test that I missed until now (contain-valid.html):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c08b60ce1749c65714a52299253bf3d25c169cae

Flags: needinfo?(dholbert)
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9f04204160ff
Drop css parser support for 'contain:style'. r=emilio
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.