1530896 - Adjust CSS parser to un-recognize `contain:style` for now

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Daniel Holbert [:dholbert] (PTO until 2/24)]

The CSSWG just discussed contain:style and resolved on the following:
* RESOLVED: remove style containment from keywords that aren't 'style'
* RESOLVED: mark 'style' at risk
* RESOLVED: Republish CR of css-contain once edits are in

https://github.com/w3c/csswg-drafts/issues/3280#issuecomment-467588765

For our initially shipping version of css containment, we're going to drop support for style from our CSS parser right now (and remove it from the content and strict keywords, per the first CSSWG resolution above).

Filing this bug on doing that.

Comment 1

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Attachment: Bug 1530896: Drop css parser support for 'contain:style'. r?emilio

We're not sure we're going to ship support for this value, and it's been marked
as 'at-risk' in the spec, so let's stop pretending we support it in the parser.

Spec issue:
https://github.com/w3c/csswg-drafts/issues/3280

Comment 2

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Try run, just to be sure I didn't miss something:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c4016c6e0f88d93b883157563191d54e720acb5

Comment 3

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Looks like we need some annotations and/or adjustments for the css/css-contain/parsing/contain-computed.html web platform test.

Comment 4

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Try run with the wpt tests (for parsing contain:style [xyz]) annotated as failing:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ebe798ec1b4d219f34898cf7c41307a0c82eeb8

Comment 5

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Once more with annotations for another test that I missed until now (contain-valid.html):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c08b60ce1749c65714a52299253bf3d25c169cae

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f04204160ff
Drop css parser support for 'contain:style'. r=emilio

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/9f04204160ff