Remove editMenuCommands.inc.xul and make editMenuOverlay.js in charge of constructing the relevant commandset DOM

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 months ago
a month ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 months ago

This would allow us to load just <script type="application/javascript" src="chrome://global/content/editMenuOverlay.js"> and remove preprocessing for https://searchfox.org/mozilla-central/search?q=editMenuCommands.inc.xul&path=.

(Assignee)

Updated

2 months ago
See Also: → 1531155
(Assignee)

Comment 1

2 months ago

This allows us to drop preprocessing and makes it simpler to add edit menu functionality to any type of document.

Blocks: 1531254

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:bgrins, could you have a look please?

Flags: needinfo?(bgrinstead)
(Assignee)

Comment 3

a month ago

(In reply to Release mgmt bot [:sylvestre / :calixte] from comment #2)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:bgrins, could you have a look please?

Was just waiting until after the merge, will land it shortly.

Flags: needinfo?(bgrinstead)
(Assignee)

Updated

a month ago
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED

Comment 4

a month ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.