Closed Bug 1531119 Opened 5 years ago Closed 5 years ago

Remove editMenuCommands.inc.xul and make editMenuOverlay.js in charge of constructing the relevant commandset DOM

Categories

(Toolkit :: General, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(1 file)

This would allow us to load just <script type="application/javascript" src="chrome://global/content/editMenuOverlay.js"> and remove preprocessing for https://searchfox.org/mozilla-central/search?q=editMenuCommands.inc.xul&path=.

See Also: → 1531155

This allows us to drop preprocessing and makes it simpler to add edit menu functionality to any type of document.

Blocks: 1531254
Priority: -- → P3

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:bgrins, could you have a look please?

Flags: needinfo?(bgrinstead)

(In reply to Release mgmt bot [:sylvestre / :calixte] from comment #2)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:bgrins, could you have a look please?

Was just waiting until after the merge, will land it shortly.

Flags: needinfo?(bgrinstead)
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: