Port bug 1531119 to Thunderbird - Remove editMenuCommands.inc.xul and make editMenuOverlay.js in charge of constructing the relevant commandset DOM

RESOLVED FIXED in Thunderbird 68.0

Status

enhancement
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: mkmelin, Assigned: mkmelin)

Tracking

Trunk
Thunderbird 68.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

3 months ago

+++ This bug was initially created as a clone of Bug #1531119 +++

editMenuCommands.inc.xul is going away and editMenuOverlay.js is instead taking care of the functionality.

Assignee

Comment 1

3 months ago

This seems to do it.

Attachment #9047296 - Flags: review?(geoff)
Comment on attachment 9047296 [details] [diff] [review]
bug1531254_editMenuCommands.inc_removal.patch

Review of attachment 9047296 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a little surprised that's the only place, but okay.
Attachment #9047296 - Flags: review?(geoff) → review+
Assignee

Updated

3 months ago
Status: NEW → ASSIGNED

Comment 3

2 months ago

Is this how xul is replaced by moving the functionality to the relevant .js file?

Assignee

Comment 4

2 months ago

This is one example yes. Bug 1489447 tracks some other prime examples.

Comment 5

2 months ago

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/2ab8c7d1987f
Port bug 1531119 - Remove editMenuCommands.inc.xul and make editMenuOverlay.js in charge of constructing the relevant commandset DOM. r=darktrojan

Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 68.0

Comment 6

2 months ago

It would be good if you could let me know BEFORE it goes bang :-( - I worked out the same patch.

Assignee

Comment 7

2 months ago

Don't know if you're referring to me or Geoff, but this patch was prepared weeks ago, and also clearly linked from the m-c bug.

Comment 8

2 months ago

Primarily you, but also Geoff for not talking to me on IRC when the bustage happened and I was looking into where it came from at 12 AM midnight :-(

It may be linked from the M-C bug, but I'm not following that.

So please in the future, adhere to this process:

If you know of incoming bustage and you're pro-actively preparing a fix, please CC me on the bug or better even, NI me on the bug with these words: "Incoming bustage, please watch bug NNNNNN and when it lands, please land the patch here".

This should really go without saying since you know very well that I do most the landings and coordinate these things overall. I can't coordinate them if I don't know about them.

Given that even M-C developers give (some) advanced warning, I expect my C-C colleagues to inform me 100% in advance.

I enclose the bugmail to prove that I got CC'ed to the bug after my comment #6:

https://bugzilla.mozilla.org/show_bug.cgi?id=1531254

Jorg K (GMT+1) <...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jorgk@jorgk.com

--- Comment #6 from Jorg K (GMT+1) <jorgk@jorgk.com> 2019-03-22 00:16:59 CET ---
It would be good if you could let me know **BEFORE** it goes bang  - I
worked out the same patch.

You weren't on IRC at the time. If you had been I would've left you to it because I had much better things to be doing at the time.

Comment 10

2 months ago

That's possible. Yesterday I had switched the "auto-connect" off to avoid noise on the channel. That said, there would have been ample opportunity to CC me on the bug.

Assignee

Comment 11

2 months ago

I'll try to remember to cc you. I'd recommend checking bugs linked from the main one though.

Comment 12

2 months ago

Which one is the "main" one? Am I to follow all de-XBL activities given that we have a team of five people doing that work?

And with 200+ bugmails a day something can slip through the cracks. It's much easier for you to draw attention to a bustage prevention bug like this one.

You need to log in before you can comment on or make changes to this bug.