1531133 - (android-pgo) Ship PGO'd Android builds

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement)

Description

[Michael Shal [:mshal]]

When bug 632954 is finished, we'll have new Android PGO builds and tests running. This bug is for any steps required to actually ship the builds.

Presumably we'll need to at least update the nightly "N" builds to use PGO. Are there any other steps required to ship?

Comment 1

[Kim Moir [:kmoir] ET]

:catlee mentioned Callek might know more about this

Comment 2

[Justin Wood (:Callek)]

Offhand, if we get the N builds to use PGO I don't think there are any more steps required. I'm more than happy to dive deeper once the patchset for 632954 is closer to landing.

We might want to make the single-locale nightlies also use it, but I'm less certain of ROI for the effort for those.

If there are artifact location changes on what we are shipping, that will need some coordination of course, but if the .apk stays in the same place I suspect everything downstream will "just work"

Comment 3

[Chris Peterson [:cpeterson]]

67=wontfix

Given PGO's stability risk and releng automation dependencies, we probably don't want to uplift PGO to 67 Beta.

Comment 4

[Chris Peterson [:cpeterson]]

Mike, I just wanted to confirm: did ARMv7 (bug 1535364) and ARM64 (bug 1543212) PGO builds of Fennec and GeckoView successfully ride the trains in the 68 release?

Comment 5

[Michael Shal [:mshal]]

(In reply to Chris Peterson [:cpeterson] from comment #4)

Mike, I just wanted to confirm: did ARMv7 (bug 1535364) and ARM64 (bug 1543212) PGO builds of Fennec and GeckoView successfully ride the trains in the 68 release?

Looks like it to me - I downloaded the 68 release source tarball and can see the PGO flags set in the Taskcluster task definitions for it. I also checked the logs on the mozilla-esr68 branch, and I can see the "-fprofile-instr-use" flag in the Nightly builds for both ARMv7 and ARM64, which means the profile data is included in those builds. I could check other specific builds if you know what revisions are of interest.

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to Michael Shal [:mshal] from comment #5)

... I also checked the logs on the mozilla-esr68 branch, and I can see the "-fprofile-instr-use" flag in the Nightly builds for both ARMv7 and ARM64, which means the profile data is included in those builds. I could check other specific builds if you know what revisions are of interest.

Thanks. Knowing that mozilla-esr68 tip is using -fprofile-instr-use is good enough. You don't need to check any specific earlier revisions.