Closed Bug 1531133 (android-pgo) Opened 4 years ago Closed 3 years ago

Ship PGO'd Android builds

Categories

(Release Engineering :: General, enhancement)

Unspecified
Android
enhancement
Not set
normal

Tracking

(firefox-esr68 verified, firefox66 wontfix, firefox67 wontfix, firefox68 verified, firefox69 verified, firefox70 verified)

RESOLVED FIXED
Tracking Status
firefox-esr68 --- verified
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- verified
firefox69 --- verified
firefox70 --- verified

People

(Reporter: mshal, Unassigned)

References

Details

(Whiteboard: [geckoview:p1])

When bug 632954 is finished, we'll have new Android PGO builds and tests running. This bug is for any steps required to actually ship the builds.

Presumably we'll need to at least update the nightly "N" builds to use PGO. Are there any other steps required to ship?

:catlee mentioned Callek might know more about this

Flags: needinfo?(bugspam.Callek)

Offhand, if we get the N builds to use PGO I don't think there are any more steps required. I'm more than happy to dive deeper once the patchset for 632954 is closer to landing.

We might want to make the single-locale nightlies also use it, but I'm less certain of ROI for the effort for those.

If there are artifact location changes on what we are shipping, that will need some coordination of course, but if the .apk stays in the same place I suspect everything downstream will "just work"

Flags: needinfo?(bugspam.Callek)
Depends on: 1535364
No longer depends on: android-pgo-ARMv7
OS: Unspecified → Android
Whiteboard: [geckoview:p1]

67=wontfix

Given PGO's stability risk and releng automation dependencies, we probably don't want to uplift PGO to 67 Beta.

Mike, I just wanted to confirm: did ARMv7 (bug 1535364) and ARM64 (bug 1543212) PGO builds of Fennec and GeckoView successfully ride the trains in the 68 release?

Alias: android-pgo
Depends on: android-pgo-ARM64
Flags: needinfo?(mshal)

(In reply to Chris Peterson [:cpeterson] from comment #4)

Mike, I just wanted to confirm: did ARMv7 (bug 1535364) and ARM64 (bug 1543212) PGO builds of Fennec and GeckoView successfully ride the trains in the 68 release?

Looks like it to me - I downloaded the 68 release source tarball and can see the PGO flags set in the Taskcluster task definitions for it. I also checked the logs on the mozilla-esr68 branch, and I can see the "-fprofile-instr-use" flag in the Nightly builds for both ARMv7 and ARM64, which means the profile data is included in those builds. I could check other specific builds if you know what revisions are of interest.

Flags: needinfo?(mshal)
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

(In reply to Michael Shal [:mshal] from comment #5)

... I also checked the logs on the mozilla-esr68 branch, and I can see the "-fprofile-instr-use" flag in the Nightly builds for both ARMv7 and ARM64, which means the profile data is included in those builds. I could check other specific builds if you know what revisions are of interest.

Thanks. Knowing that mozilla-esr68 tip is using -fprofile-instr-use is good enough. You don't need to check any specific earlier revisions.

You need to log in before you can comment on or make changes to this bug.