Closed Bug 1535364 Opened 4 years ago Closed 4 years ago

Enable PGO on Android ARMv7 Nightlies

Categories

(Firefox Build System :: General, enhancement)

ARM
Android
enhancement
Not set
normal

Tracking

(firefox-esr60 wontfix, firefox66 wontfix, firefox67 wontfix, firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox-esr60 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- fixed

People

(Reporter: mshal, Assigned: mshal)

References

Details

(Whiteboard: [geckoview:p1])

Attachments

(2 files)

With bug 632954 we'll have new Android PGO builds, but to actually ship them we'll need to enable PGO on the nightlies.

OS: Unspecified → Android
Whiteboard: [geckoview:p1]

Hi Tom, I'm planning to land this for Mike on Tuesday morning if the builds are looking ok by then, I can't quite tell if the comment you left in phabricator needs to be addressed, is this ready to land? Thank you.

Flags: needinfo?(mozilla)

I'd definitely prefer to be more defensive in calculating the dependency name here.

Flags: needinfo?(mozilla)
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/963d97e812f9
Enable PGO for Android nightly builds; r=tomprince
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Depends on: 1539933

Backed out changeset 963d97e812f9 (bug 1535364) for causing Bug 1539933. a=backout

Backout:
https://hg.mozilla.org/mozilla-central/rev/04bd7929b499d25fc538e516fc3de1aa6e9d79dc

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla68 → ---

As far as I can tell this is due to the jarlog re-ordering. Mike, can we turn this off for now and re-land in order to get more testing of PGO in nightly or is it a quick fix?

Flags: needinfo?(mh+mozilla)

Don't pass a jarlog to packager.py?

Flags: needinfo?(mh+mozilla)
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5bbf48aeb714
Turn off jarlog re-ordering for Android PGO due to problems publishing APKs. r=glandium
https://hg.mozilla.org/integration/autoland/rev/b9654a90f60a
Enable PGO for Android nightly builds; r=tomprince
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
See Also: → 1542707
Blocks: 1543215
Hardware: Unspecified → ARM
Summary: Enable PGO on Android nightlies → Enable PGO on Android ARMv7 Nightlies
No longer depends on: android-pgo-ARM64
You need to log in before you can comment on or make changes to this bug.