1535364 - Enable PGO on Android ARMv7 Nightlies

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Michael Shal [:mshal]]

With bug 632954 we'll have new Android PGO builds, but to actually ship them we'll need to enable PGO on the nightlies.

Comment 1

[Michael Shal [:mshal]]

Attachment: Bug 1535364 - Enable PGO for Android nightly builds; r?tomprince

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Hi Tom, I'm planning to land this for Mike on Tuesday morning if the builds are looking ok by then, I can't quite tell if the comment you left in phabricator needs to be addressed, is this ready to land? Thank you.

Comment 3

[Tom Prince [:tomprince]]

I'd definitely prefer to be more defensive in calculating the dependency name here.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/963d97e812f9
Enable PGO for Android nightly builds; r=tomprince

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/963d97e812f9

Comment 6

[Dorel Luca [:dluca]]

Backed out changeset 963d97e812f9 (bug 1535364) for causing Bug 1539933. a=backout

Backout:
https://hg.mozilla.org/mozilla-central/rev/04bd7929b499d25fc538e516fc3de1aa6e9d79dc

Comment 7

[Chris Manchester (limited bugmail, email directly)]

As far as I can tell this is due to the jarlog re-ordering. Mike, can we turn this off for now and re-land in order to get more testing of PGO in nightly or is it a quick fix?

Comment 8

[Mike Hommey [:glandium]]

Don't pass a jarlog to packager.py?

Comment 9

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1535364 - Turn off jarlog re-ordering for Android PGO due to problems publishing APKs.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bbf48aeb714
Turn off jarlog re-ordering for Android PGO due to problems publishing APKs. r=glandium
https://hg.mozilla.org/integration/autoland/rev/b9654a90f60a
Enable PGO for Android nightly builds; r=tomprince

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5bbf48aeb714
https://hg.mozilla.org/mozilla-central/rev/b9654a90f60a