1531218 - Size of ch unit is incorrect with text-orientation: mixed and writing-mode: vertical-rl

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Gérard Talbot]

When styling 'height' with 'text-orientation: mixed' and 'writing-mode: vertical-rl', the ch unit corresponds to the the advance width measure of the 0 (ZERO, U+0030) glyph.

Tests

http://w3c-test.org/css/css-values/ch-unit-003.html

http://w3c-test.org/css/css-values/ch-unit-010.html

Notes

• Chromium 72.0.3626.96 passes these tests
• Firefox 60.5.1 ESR and Firefox 67.0a1 buildID=20190227163104 fail these tests
• I searched for duplicate and did not find any
• This bug report is not related to bug 1470075.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It may be relevant that Gecko_GetFontMetrics considers an aIsVertical parameter but doesn't appear to consider the text-orientation. (It should in turn get the value computed for zeroOrAveCharWidth.)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

See the css-values-3 spec and the css-values-4 spec, which for the purposes of this bug are basically identical.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

I knew I had reviewed a patch to fix this. Looks like bug 282126 never landed.

Comment 4

[Cameron McCormack (:heycam)]

Er, yes, looks like I forgot about that.

Comment 6

[Gérard Talbot]

All the ch-unit test results:

https://wpt.fyi/results/css/css-values?q=ch-unit-0

and the 003 and 010 ones (tests and test results):

https://wpt.fyi/results/css/css-values/ch-unit-003.html

http://wpt.live/css/css-values/ch-unit-003.html

https://wpt.fyi/results/css/css-values/ch-unit-010.html

http://wpt.live/css/css-values/ch-unit-010.html

Resolving as FIXED