Open Bug 1531311 Opened 2 years ago Updated 1 year ago

Improve UX when picking elements on remote browsers

Categories

(DevTools :: about:debugging, enhancement, P3)

67 Branch
enhancement

Tracking

(firefox65 unaffected, firefox66 unaffected, firefox67 affected)

Tracking Status
firefox65 --- unaffected
firefox66 --- unaffected
firefox67 --- affected

People

(Reporter: hani.yacoub, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(3 obsolete files)

[Affected versions]:
Nightly 67.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.14, and Ubuntu 16.04 x64.

[Steps to reproduce]:

  1. Make sure that you are connected to a mobile device using about:debugging, following these steps:
    a. In about:config set:
  2. From "about:debugging" make sure to be connected to a mobile device.
  3. On your mobile device open many tabs (ex. reddit.com, amazon.com) and make sure this is reflected in the Desktop UI.
  4. Inspect any of the opened tabs.
  5. Click on "Pick an element from the page".

[ Expected result]:
Should remove the feature.
Future plans: Show the UI of the Device in about:devtools-toolbox

[Actual result]:
It's not possible to pick an element from the page when you are connected via USB

Priority: -- → P3

I suppose this was discussed in the standup, but the idea for now is just to hide the feature in about:devtools-toolbox.

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Type: defect → enhancement
Priority: P3 → P1
Whiteboard: [remote-debugging-reserve]

My plan here would be to only disable/remove the feature when the debugged target is on a remote browser. It can still be helpful when debugging a local addon for instance, so completely removing it doesn't sound great.

We should still decide whether it's best to hide the icon completely or to disable it with a tooltip (eg "Unavailable when debugging a remote browser").

Depends on D28065

Using split("-") was clashing with the connection type "this-firefox".
Renamed to "this_firefox" for now.
Added unit test for remote-client-manager.

Is it really broken?

I've not tested with a device, but it still works when debugging a "remote" firefox.
When you click on "pick an element", we expect you to click on the element you want to inspect on the remote.
On a remote firefox, you have to click on an element in the debugged tab, you will see the highlighter working.
On a remote device, you have to touch your screen, on the debugged tab to select an element. The highlighter should display the selected element.

Now. It isn't working like chrome devtools which replicated the device screen, but it still works and is useful.

Attachment #9059269 - Attachment description: Bug 1531311 - Hide framePicker button for remote targets → Bug 1531311 - Hide element Picker button for remote targets
Attachment #9059271 - Attachment description: Bug 1531311 - Add mochitest for framepicker display with remote targets → Bug 1531311 - Add mochitest for element picker display with remote targets

Indeed it works! Just tried with a device, and yes if you touch the screen of the device after clicking on the element picker button you will select it in the inspector.

The lack of user feedback and explanations make it feel broken to me. I wonder if this feels intuitive to others?

I won't push further for disabling the button, but I think we should have some user feedback here. Maybe a message saying "click or touch the element you want to select in your remote browser" displayed in the toolbox? Or maybe a message in the remote browser (although it may hide the element you actually want to touch so maybe not a great idea...)

I will cancel the review requests here, I will just spawn another bug to fix the remote-client-manager bug I spotted while writing the patches here.

Attachment #9059269 - Attachment is obsolete: true
Attachment #9059271 - Attachment is obsolete: true
Assignee: jdescottes → nobody
Status: ASSIGNED → NEW
Priority: P1 → P3
Summary: Can't pick an element from the page via USB connection → Improve UX when picking elements on remote browsers
See Also: → 1545482

Comment on attachment 9059270 [details]
Bug 1531311 - THIS_FIREFOX connection type is not recognized;r=ladybenko

Revision D28066 was moved to bug 1545482. Setting attachment 9059270 [details] to obsolete.

Attachment #9059270 - Attachment is obsolete: true
Whiteboard: [remote-debugging-reserve]
You need to log in before you can comment on or make changes to this bug.