Closed Bug 1545482 Opened 5 months ago Closed 5 months ago

[remote-dbg-next] RemoteClientManager fails to return the connection type for this-firefox remote ids

Categories

(DevTools :: about:debugging, enhancement, P1)

enhancement

Tracking

(firefox68 fixed)

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

(Whiteboard: [remote-debugging-reserve] remote-debugging-technical-debt)

Attachments

(1 file)

Spotted while working on Bug 1531311.

The remote-client-manager will not be able to correctly return the connection type if the connection is of type "this-firefox". This is because we split on "-" to extract the type from the remote id, and obviously this fails for "someid-this-firefox".

Depends on D28065

Using split("-") was clashing with the connection type "this-firefox".
Renamed to "this_firefox" for now.
Added unit test for remote-client-manager.

Whiteboard: remote-debugging-technical-debt → [remote-debugging-reserve] remote-debugging-technical-debt
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b0f3d584835c
THIS_FIREFOX connection type is not recognized;r=ladybenko
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.