1531500 - Distorted/slowed-down audio with HE-AAC streams

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[[:philipp]]

str on win10 64bit:

• play-back a video on the bbc website, for example https://www.bbc.co.uk/news/av/world-47407139/trump-kim-summit-us-president-emerges-the-biggest-loser
• the audio is sounding very distorted (like it's playing in super slow-motion)

this regressed on 67.0a1 in this range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=198cd4a81bf2afa7cc79360f90da7bc91218b76d&tochange=fd53d5e80bca0316495a677b4155dabb1b771569

i'm getting errors in mozregression when trying to narrow it down more closely, but manually testing a few builds on autoland i think the issue has been introduced with the patches from bug 1530234.

Comment 1

[[:philipp]]

a friend tested on ubuntu where these steps didn't reproduce.

Comment 2

[Jean-Yves Avenard [:jya]]

That sounds very funny :)

Comment 3

[Greg ( Hank1 )]

i also get the same problem on https://www.essendonfc.com.au/

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1531500 - Fix HE-AAC with WMF decoder. r?bryce,gerald

The rate changes after decoding the first sample to what was indicated in the container. The code to handle that case was incorrectly removed in bug 1530234

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62d4e16fbb2b
Fix HE-AAC with WMF decoder. r=cpearce

Comment 6

[lhzhou.e]

Same here when playing video on Facebook.

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/62d4e16fbb2b

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

I just tested with 03-01 Nightly build 20190301201651 and the amazon prime video playsback as expected. Yay!

Comment 11

[Oana Botisan, Desktop QA]

I managed to reproduce the issue using an older version of Nightly from 2019-02-28 on Windows 10 x64.
I retested everything using latest Nightly 68.0a1 and beta 67.0b8 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13. The bug is not reproducing anymore.