Closed
Bug 1531591
Opened 6 years ago
Closed 6 years ago
WebExtensions API for creating/modifying/deleting folders
Categories
(Thunderbird :: Add-Ons: Extensions API, enhancement)
Thunderbird
Add-Ons: Extensions API
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 68.0
People
(Reporter: darktrojan, Assigned: darktrojan)
References
Details
Attachments
(1 file)
|
13.13 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9056796 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9056796 [details] [diff] [review]
1531591-webext-folders-1.diff
Review of attachment 9056796 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM, r=mkmelin
::: mail/components/extensions/parent/ext-accounts.js
@@ +53,5 @@
> }
> return null;
> },
> + async createSubfolder({ accountId, path: parentPath }, childName) {
> + let URI = folderPathToURI(accountId, parentPath);
nit: would keep the name lowercase uri
Attachment #9056796 -
Flags: review?(mkmelin+mozilla) → review+
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/d4d8a011185b
WebExtensions API for creating/modifying/deleting folders; r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 68.0
You need to log in
before you can comment on or make changes to this bug.
Description
•