Ship String.prototype.matchAll method

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

({dev-doc-complete})

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(2 attachments)

Remaining work:

  • Send an intent-to-ship.
  • Remove the NIGHTLY_ONLY ifdef.
  • Tweak and re-run test262-update.py for test coverage.

anba, do you want to write the intent-to-ship email, or would you rather I do this? It's no trouble either way...

Flags: needinfo?(andrebargull)

Intent-to-ship sent.

(In reply to Jason Orendorff [:jorendorff] from comment #2)

Intent-to-ship sent.

Thanks!

Flags: needinfo?(andrebargull)
Assignee: nobody → jorendorff

No pref; the feature is not risky or complicated enough to warrant it. It's
easy enough to back this out if need be.

The previous patch makes both String.prototype.matchAll and Symbol.matchAll
unconditional features.

This patch was made by first making the changes to test262-update.py, then
re-running it against the test262 revision already indicated by
js/src/tests/test262/GIT-INFO: python test262-update.py --revision 59b89a1c834faadc359aecc882587b513877b59b.

Depends on D22370

Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e36d2c8de6c6
Part 1: Ship String.prototype.matchAll and Symbol.matchAll. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/14391e1ce086
Part 2: Update test262 to run matchAll tests unconditionally. r=jwalden
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.