1531830 - Ship String.prototype.matchAll method

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jason Orendorff [:jorendorff]]

Remaining work:

• Send an intent-to-ship.
• Remove the NIGHTLY_ONLY ifdef.
• Tweak and re-run test262-update.py for test coverage.

Comment 1

[Jason Orendorff [:jorendorff]]

anba, do you want to write the intent-to-ship email, or would you rather I do this? It's no trouble either way...

Comment 2

[Jason Orendorff [:jorendorff]]

Intent-to-ship sent.

Comment 3

[André Bargull [:anba]]

(In reply to Jason Orendorff [:jorendorff] from comment #2)

Intent-to-ship sent.

Thanks!

Comment 4

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1531830 - Part 1: Ship String.prototype.matchAll and Symbol.matchAll. r?jwalden

No pref; the feature is not risky or complicated enough to warrant it. It's
easy enough to back this out if need be.

Comment 5

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1531830 - Part 2: Update test262 to run matchAll tests unconditionally. r?jwalden

The previous patch makes both String.prototype.matchAll and Symbol.matchAll
unconditional features.

This patch was made by first making the changes to test262-update.py, then
re-running it against the test262 revision already indicated by
js/src/tests/test262/GIT-INFO: python test262-update.py --revision 59b89a1c834faadc359aecc882587b513877b59b.

Depends on D22370

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e36d2c8de6c6
Part 1: Ship String.prototype.matchAll and Symbol.matchAll. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/14391e1ce086
Part 2: Update test262 to run matchAll tests unconditionally. r=jwalden

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e36d2c8de6c6
https://hg.mozilla.org/mozilla-central/rev/14391e1ce086

Comment 8

[Florian Scholz (Open Web Docs)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1435829#c35 for doc work that has been completed.
Marked as shipping in Firefox 67 https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/67#JavaScript