Perma TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_xrayToJS.xul | A symbol-keyed property on the RegExp prototype has been changed! You need a security audit from an XPConnect peer when Gecko 67 merges to Beta on 2019-03-12

VERIFIED FIXED in Firefox 67

Status

()

defect
VERIFIED FIXED
3 months ago
2 months ago

People

(Reporter: apavel, Assigned: jorendorff)

Tracking

Trunk
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(thunderbird_esr60 unaffected, firefox-esr60 unaffected, firefox65 unaffected, firefox66 unaffected, firefox67+ verified)

Details

Attachments

(1 attachment)

Reporter

Description

3 months ago

[Tracking Requested - why for this release]:

Central as Beta simulation

Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=3f3d34b84714a0e2f97bbd1a4cf06ef9df707a21&selectedJob=232417095

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=232417095&repo=try&lineNumber=1499

13:51:06 INFO - TEST-START | js/xpconnect/tests/chrome/test_xrayToJS.xul
13:51:06 INFO - GECKO(1976) | ++DOMWINDOW == 36 (0x11dce1400) [pid = 1976] [serial = 89] [outer = 0x1276e6f20]
13:51:06 INFO - GECKO(1976) | ++DOCSHELL 0x11d79d800 == 15 [pid = 1976] [id = {7bde182e-b124-f64d-9d1c-25f2f112e108}]
13:51:06 INFO - GECKO(1976) | ++DOMWINDOW == 37 (0x1297997a0) [pid = 1976] [serial = 90] [outer = 0x0]

13:51:08 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | stack property should be correct
13:51:08 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | Xrays should never get an overwritten stack property.
13:51:08 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | A property on the RegExp prototype has changed! You need a security audit from an XPConnect peer
13:51:08 INFO - Buffered messages finished
13:51:09 INFO - TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_xrayToJS.xul | A symbol-keyed property on the RegExp prototype has been changed! You need a security audit from an XPConnect peer - got "["Symbol.match", "Symbol.matchAll", "Symbol.replace", "Symbol.search", "Symbol.split"]", expected "["Symbol.match", "Symbol.replace", "Symbol.search", "Symbol.split"]"
13:51:09 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:320:16
13:51:09 INFO - testXray@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xul:422:5
13:51:09 INFO - testRegExp@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xul:872:5
13:51:09 INFO - go@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xul:144:5
13:51:09 INFO - onload@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xul:1:1

Olli, is this from Bug 1412485? Can you please take a look?

Flags: needinfo?(bugs)

test_xrayToJS.xul doesn't have anything to do with touch API, so hard to see how it could be.

This smells more like about the recent changes to compartments.

No longer blocks: 1412485
Flags: needinfo?(bugs)
Blocks: 1531830
Flags: needinfo?(jorendorff)
Assignee

Comment 3

3 months ago

Oh. I know exactly what this is. Patch coming.

Assignee: nobody → jorendorff
Flags: needinfo?(jorendorff)

Comment 5

3 months ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/95f9efbbf805
Add Symbol.matchAll to list of expected RegExp methods. r=peterv

Comment 6

3 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.