1531944 - Remove Legacy Debugger Code from devtools/client/shared/sourceeditor/debugger.js

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P3)

Description

[David Walsh :davidwalsh]

As mentioned by Jason, the following code is probably no longer necessary in MC:

https://searchfox.org/mozilla-central/source/devtools/client/shared/sourceeditor/debugger.js#34-221

We should remove and run tests to ensure everything is still working properly.

Comment 1

[Paarmita Bhargava]

Hey,
I would like to work on it. Can you please assign it to me?

Comment 2

[Helena Moreno (aka helenatxu)]

(In reply to Paarmita Bhargava from comment #1)

Hello Jason! If you don't assign this bug to Paarmita, could you asign it to me? Thank you

Comment 3

[Jason Laster [:jlast]]

Thanks Helena for your interest, I'll look for another good issue

Comment 4

[Jason Laster [:jlast]]

Helena, this might be a good issue - https://bugzilla.mozilla.org/show_bug.cgi?id=1463427

Comment 5

[Erik Carrillo [:E_Carr]]

Hi, Jason I noticed this bug was assigned a couple of days ago but there hasn't been any activity on it.

Would it be an issue if I work on it? Thanks.

Comment 6

[Paarmita Bhargava]

Hey Erik, I was working on it.

Comment 7

[Helena Moreno (aka helenatxu)]

(In reply to Jason Laster [:jlast] from comment #4)

Helena, this might be a good issue - https://bugzilla.mozilla.org/show_bug.cgi?id=1463427

Hey Jason, I see you already assigned the bug to my colleague Erik. Could you suggest me another one? Thanks!

Comment 8

[Paarmita Bhargava]

Attachment: Bug 1531944 - Remove Legacy Debugger Code

Comment 9

[Jason Laster [:jlast]]

Parrmita, are you still interested in working on this?

Comment 10

[Armando Ferreira]

Hi Jason, Can I take this bug?

Comment 11

[sagudev]

Attachment: rm_old_js_debugger.diff

I checked and it seems that devtools/client/shared/sourceeditor/debugger.js is not used anywhere anymore. So I deleted as you suggested in https://phabricator.services.mozilla.com/D22354
Are there any test that needs to be deleted?

Comment 12

[Varun [he/him IST]]

Hey Jason, this seems like inactive. Can I take this up?

Comment 13

[Nicolas Chevobbe [:nchevobbe]]

Hello Varun, Armando, sagudev, are you still interested by this bug? I'll assign the bug to the first person to answer :)

Comment 14

[Varun [he/him IST]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #13)

Hello Varun, Armando, sagudev, are you still interested by this bug? I'll assign the bug to the first person to answer :)

Im interested in taking it up.

Comment 15

[Nicolas Chevobbe [:nchevobbe]]

Great, it's now yours :)

If it's your first bug, you might want to read this https://firefox-source-docs.mozilla.org/devtools/getting-started/README.html to setup the work environment.
Make sure to select "Artifact builds" when asked as it speeds up the workflow quite a bit :)
Also, you can come and chat on Matrix https://chat.mozilla.org/#/room/#devtools:mozilla.org

Comment 16

[Varun [he/him IST]]

So I tried removing the selected lines but there is a dangling curly brace at https://searchfox.org/mozilla-central/source/devtools/client/shared/sourceeditor/debugger.js#231. Not sure if I should remove this curly brace or move the https://searchfox.org/mozilla-central/source/devtools/client/shared/sourceeditor/debugger.js#222-230 inside a function

Comment 17

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Varun [he/him IST] from comment #16)

So I tried removing the selected lines but there is a dangling curly brace at https://searchfox.org/mozilla-central/source/devtools/client/shared/sourceeditor/debugger.js#231. Not sure if I should remove this curly brace or move the https://searchfox.org/mozilla-central/source/devtools/client/shared/sourceeditor/debugger.js#222-230 inside a function

The file is never used (https://searchfox.org/mozilla-central/search?q=sourceeditor%2Fdebugger&path=&case=true&regexp=false), so we can remove it :)
Make sure to remove the reference in https://searchfox.org/mozilla-central/source/devtools/client/shared/sourceeditor/moz.build

Comment 18

[Varun [he/him IST]]

Attachment: Bug 1531944 - Remove unused file `debugger.js`. r?nchevobbe

Comment 19

[Varun [he/him IST]]

Attachment: Bug 1531944. Remove file `debugger.js`

Depends on D84562

Comment 20

[Varun [he/him IST]]

Attachment: Bug 1531944 - Remove unused devtools/client/shared/sourceeditor/debugger.js. r=nchevobbe

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1a51d2acb60
Remove unused devtools/client/shared/sourceeditor/debugger.js. r=nchevobbe

Comment 22

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b1a51d2acb60