Closed Bug 1531944 Opened 2 years ago Closed 2 months ago

Remove Legacy Debugger Code from devtools/client/shared/sourceeditor/debugger.js

Categories

(DevTools :: Debugger, task, P3)

task

Tracking

(firefox80 fixed)

RESOLVED FIXED
Firefox 80
Tracking Status
firefox80 --- fixed

People

(Reporter: davidwalsh, Assigned: varundey20)

References

Details

(Keywords: good-first-bug, helpwanted)

Attachments

(2 files, 3 obsolete files)

As mentioned by Jason, the following code is probably no longer necessary in MC:

https://searchfox.org/mozilla-central/source/devtools/client/shared/sourceeditor/debugger.js#34-221

We should remove and run tests to ensure everything is still working properly.

Priority: -- → P3

Hey,
I would like to work on it. Can you please assign it to me?

(In reply to Paarmita Bhargava from comment #1)

Hello Jason! If you don't assign this bug to Paarmita, could you asign it to me? Thank you

Assignee: nobody → paarmita1998

Thanks Helena for your interest, I'll look for another good issue

Helena, this might be a good issue - https://bugzilla.mozilla.org/show_bug.cgi?id=1463427

Flags: needinfo?(helenaenred)

Hi, Jason I noticed this bug was assigned a couple of days ago but there hasn't been any activity on it.

Would it be an issue if I work on it? Thanks.

Hey Erik, I was working on it.

(In reply to Jason Laster [:jlast] from comment #4)

Helena, this might be a good issue - https://bugzilla.mozilla.org/show_bug.cgi?id=1463427

Hey Jason, I see you already assigned the bug to my colleague Erik. Could you suggest me another one? Thanks!

Flags: needinfo?(helenaenred)
Type: enhancement → task

Parrmita, are you still interested in working on this?

Flags: needinfo?(paarmita1998)

Hi Jason, Can I take this bug?

I checked and it seems that devtools/client/shared/sourceeditor/debugger.js is not used anywhere anymore. So I deleted as you suggested in https://phabricator.services.mozilla.com/D22354
Are there any test that needs to be deleted?

Attachment #9078037 - Flags: review+

Hey Jason, this seems like inactive. Can I take this up?

Flags: needinfo?(jlaster)

Hello Varun, Armando, sagudev, are you still interested by this bug? I'll assign the bug to the first person to answer :)

Assignee: paarmita1998 → nobody
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Attachment #9048935 - Attachment is obsolete: true

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #13)

Hello Varun, Armando, sagudev, are you still interested by this bug? I'll assign the bug to the first person to answer :)

Im interested in taking it up.

Great, it's now yours :)

If it's your first bug, you might want to read this https://firefox-source-docs.mozilla.org/devtools/getting-started/README.html to setup the work environment.
Make sure to select "Artifact builds" when asked as it speeds up the workflow quite a bit :)
Also, you can come and chat on Matrix https://chat.mozilla.org/#/room/#devtools:mozilla.org

Assignee: nchevobbe → varundey20
Flags: needinfo?(paarmita1998)
Flags: needinfo?(jlaster)

So I tried removing the selected lines but there is a dangling curly brace at https://searchfox.org/mozilla-central/source/devtools/client/shared/sourceeditor/debugger.js#231. Not sure if I should remove this curly brace or move the https://searchfox.org/mozilla-central/source/devtools/client/shared/sourceeditor/debugger.js#222-230 inside a function

Flags: needinfo?(nchevobbe)

(In reply to Varun [he/him IST] from comment #16)

So I tried removing the selected lines but there is a dangling curly brace at https://searchfox.org/mozilla-central/source/devtools/client/shared/sourceeditor/debugger.js#231. Not sure if I should remove this curly brace or move the https://searchfox.org/mozilla-central/source/devtools/client/shared/sourceeditor/debugger.js#222-230 inside a function

The file is never used (https://searchfox.org/mozilla-central/search?q=sourceeditor%2Fdebugger&path=&case=true&regexp=false), so we can remove it :)
Make sure to remove the reference in https://searchfox.org/mozilla-central/source/devtools/client/shared/sourceeditor/moz.build

Flags: needinfo?(nchevobbe)
Attached file Bug 1531944. Remove file `debugger.js` (obsolete) —

Depends on D84562

Attachment #9165462 - Attachment is obsolete: true
Attachment #9165460 - Attachment is obsolete: true
Attachment #9165478 - Attachment description: Bug 1531944 - Remove unused file `debugger.js`. r?nchevobbe → Bug 1531944 - Remove unused devtools/client/shared/sourceeditor/debugger.js`. r=nchevobbe
Attachment #9165478 - Attachment description: Bug 1531944 - Remove unused devtools/client/shared/sourceeditor/debugger.js`. r=nchevobbe → Bug 1531944 - Remove unused devtools/client/shared/sourceeditor/debugger.js. r=nchevobbe
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b1a51d2acb60
Remove unused devtools/client/shared/sourceeditor/debugger.js. r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80
You need to log in before you can comment on or make changes to this bug.