1532077 - label for reconfiguring extension keyboard shortcut for browser action needs improved text, sounds like extension wouldn't do anything if it doesn't get called

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1303384 allows to configure shortcut for browser extensions, also for built-in functions they use like the browser action. The label for that is:

shortcuts-browserAction = Activate extension

From https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_action

"A browser action is a button that your extension adds to the browser's toolbar."

The extension can be active without calls to the browser action. The label doesn't properly describe what it does.

Comment 1

[David Durst [:ddurst]]

This is releasing in 66, so we should adjust this as soon as we can.

Comment 2

[Mark Striemer [:mstriemer]]

Meridel, I think we weren't sold on this string when we chose it, but maybe we should change it? Perhaps something like "Activate toolbar button" would be more appropriate? "Activate" might not be the right word, though.

Comment 3

[Meridel [:meridel]]

Discussed with Mark. "Activate toolbar button" works.

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: Bug 1532077 - Clarify browserAction message in shortcuts UI r?rpl

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af4a1de0a11c
Clarify browserAction message in shortcuts UI r=fluent-reviewers,rpl

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/af4a1de0a11c