1532173 - remove some unused references to RDF in cpp files

Status: RESOLVED FIXED

(MailNews Core :: Backend, enhancement)

Description

[:aceman]

Cpp files including RDF headers, but use no RDF functions:

mailnews/base/src/nsMsgAccountManager.cpp
46 #include "nsIRDFService.h"
47 #include "nsRDFCID.h"

mailnews/base/src/nsMsgAccountManager.h
32 class nsIRDFService;

mailnews/base/util/nsMsgIncomingServer.cpp
39 #include "nsIRDFService.h"
40 #include "nsRDFCID.h"

mailnews/news/src/nsNewsDownloader.cpp
16 #include "nsRDFCID.h"

Comment 1

[:aceman]

Attachment: 1532173.patch

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=b81c2e1f6c39be5ac996724cf8912085b2586730

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9048058 [details] [diff] [review]
1532173.patch

Thanks. When will RDF be gone completely?

Comment 3

[:aceman]

There are still tons of references, but hopefully grouped into only 2-3 features. I'm going to file a bug.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b24cc1864097
remove some unused RDF includes. r=jorgk

Comment 5

[Jorg K (CEST = GMT+2)]

(In reply to :aceman from comment #3)

There are still tons of references, but hopefully grouped into only 2-3 features. I'm going to file a bug.

Tons? I thought BenC was onto them in bug 1527764 and bug 1527772.

Comment 6

[Ben Campbell]

Aside from bug 1527764 and bug 1527772, there's rdf use in FeedUtils.jsm, which I've not yet dug into in any depth. However, it seems that it's a factor in my RDF changes not working for RSS feeds, so that's what I'm doing now :-)

Oh, there's also nsMsgRDFDataSource which I think is now unused (will create a bug for it).

Comment 7

[:aceman]

Yes, Feeds for multiple functions.