1532281 - Switch from dbus-glib to GDBus

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P2)

Description

[Marc-Antoine Perennou]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

Build firefox with --enable-dbus

Actual results:

dbus-glib is required

Expected results:

GDBus should be used instead, as dbus-glib is deprecated in favor of it, see the message at the bottom of https://dbus.freedesktop.org/doc/dbus-glib/

Comment 1

[Carsten Schoenert]

Now that Firefox was getting rid of any GTK 2 dependency, any planned progress on this part to get off the old dbus-glib stuff?

Comment 2

[David Heidelberg [:okias]]

Docs: https://developer.gnome.org/gio/stable/ch35.html
Example of conversion: https://bugs.freedesktop.org/show_bug.cgi?id=45792
GDBus example: https://stackoverflow.com/questions/37185735/sample-program-for-gdbus-signals

If anyone gets interested to giving a shot.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1532281 [Linux] Don't use dbus_connection_setup_with_g_main() in nsDBusRemote r?emilio

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1532281 [Linux] Remove dbus-glib code from GRefPtr.h r?emilio

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1532281 [Linux] Don't build with dbus-glib r?glandium

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8be358911e03
[Linux] Don't use dbus_connection_setup_with_g_main() in nsDBusRemote r=emilio

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8be358911e03

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03e70211b761
[Linux] Remove dbus-glib code from GRefPtr.h r=emilio

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50b448b2d902
[Linux] Don't build with dbus-glib r=glandium

Comment 10

[Serban Stanca [:SerbanS]]

Backed out for causing Linux build bustages.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/workspace/obj-build/dist/system_wrappers/dbus/dbus.h:3:15: fatal error: 'dbus/dbus.h' file not found

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1532281 [Linux] Remove dbus-glib code from DbusWifiScanner r?emilio

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42d664dd0316
[Linux] Remove dbus-glib code from DbusWifiScanner r=emilio,necko-reviewers,valentin

Comment 13

[Cristina Horotan [:chorotan]]

Backed out changeset 8be358911e03 (Bug 1532281) for breaking link opening from other applications (Bug 1851584)

Backed out on request: https://hg.mozilla.org/integration/autoland/rev/b55dd993355aee9644fe61c90aff8bb806f7b839

Comment 14

[Martin Stránský [:stransky] (ni? me)]

Hm, patches are already submitted in Bug 1851584.

Comment 15

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/03e70211b761
https://hg.mozilla.org/mozilla-central/rev/42d664dd0316

Comment 16

[Cosmin Sabou [:CosminS]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/b55dd993355a

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f614b12a965
[Linux] Don't build with dbus-glib r=glandium

Comment 18

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5f614b12a965

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Do we need to update the Linux system requirements for 120+?
https://www.mozilla.org/en-US/firefox/120.0a1/system-requirements/

Comment 20

[Martin Stránský [:stransky] (ni? me)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #19)

Do we need to update the Linux system requirements for 120+?
https://www.mozilla.org/en-US/firefox/120.0a1/system-requirements/

Yes. Bug 1858889 may be related.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Thanks, removed from the Fx121 notes.