1848589 - Migrate UPowerClient from dbus-glib to GDBus

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Martin Stránský [:stransky] (ni? me)]

Migrate UPowerClient from dbus-glib to GDBus

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: WIP

Comment 2

[Martin Stránský [:stransky] (ni? me)]

There's no point to migrate PowerClient from dbus-glib to GDBus as API battery is not used at all. Let's disable to query battery state now.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1848589 [Linux] Don't query battery status on Linux as battery API is not used r?emilio

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f563d154541
[Linux] Don't query battery status on Linux as battery API is not used r=emilio

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7f563d154541

Comment 6

[[:fabrice] Fabrice Desré]

We still use the battery api in b2g. What's the long term plan here?

Comment 7

[Martin Stránský [:stransky] (ni? me)]

(In reply to [:fabrice] Fabrice Desré from comment #6)

We still use the battery api in b2g. What's the long term plan here?

But that's Android and not Linux implementation, right?

Comment 8

[[:fabrice] Fabrice Desré]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #7)

(In reply to [:fabrice] Fabrice Desré from comment #6)

We still use the battery api in b2g. What's the long term plan here?

But that's Android and not Linux implementation, right?

No, we have support for devices like the Pinephone and Librem5 for https://capyloon.org that are "regular linux".

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Would there be any chance of b2g folks contributing a migration of this code from dbus-glib to AsyncDBus?

Comment 10

[[:fabrice] Fabrice Desré]

We can try, but it's hard to promise anything. @emilio, are you talking about migrating to https://docs.gtk.org/gio/migrating-gdbus.html ?

Comment 11

[Emilio Cobos Álvarez [:emilio]]

Yes, but we have C++-promise wrappers for gdbus already in the tree here, so it should be using those ideally (should also be easier to get the calls right).

Comment 12

[Martin Stránský [:stransky] (ni? me)]

I'm looking at it right now.